Skip to content

Commit 152f139

Browse files
authored
feat: redis source 1.0 (#327)
This sets `release-as: 1.0` for the Redis source. It also fixes a copy/paste error in `release-please.yml` that caused the Redis Source to attempt to run a release when it wasn't necessary. I've made a arbitrary but useful change in `redis_source.hpp` so it's a releasable unit.
1 parent c16d3dd commit 152f139

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

.github/workflows/release-please.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,11 +77,11 @@ jobs:
7777
os: [ ubuntu-latest, windows-2022, macos-12 ]
7878
runs-on: ${{ matrix.os }}
7979
needs: [ 'release-please' ]
80-
if: ${{ needs.release-please.outputs.package-server-released }}
80+
if: ${{ needs.release-please.outputs.package-server-redis-released }}
8181
outputs:
82-
hashes-linux: ${{ steps.release-server.outputs.hashes-linux }}
83-
hashes-windows: ${{ steps.release-server.outputs.hashes-windows }}
84-
hashes-macos: ${{ steps.release-server.outputs.hashes-macos }}
82+
hashes-linux: ${{ steps.release-server-redis.outputs.hashes-linux }}
83+
hashes-windows: ${{ steps.release-server-redis.outputs.hashes-windows }}
84+
hashes-macos: ${{ steps.release-server-redis.outputs.hashes-macos }}
8585
steps:
8686
- uses: actions/checkout@v3
8787
- id: release-server-redis

libs/server-sdk-redis-source/include/launchdarkly/server_side/integrations/redis/redis_source.hpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,8 @@ class RedisDataSource final : public ISerializedDataReader {
6363
RedisDataSource(std::unique_ptr<sw::redis::Redis> redis,
6464
std::string prefix);
6565

66-
std::string key_for_kind(ISerializedItemKind const& kind) const;
66+
[[nodiscard]] std::string key_for_kind(
67+
ISerializedItemKind const& kind) const;
6768

6869
std::string const prefix_;
6970
std::string const inited_key_;

release-please-config.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,7 @@
2424
"extra-files": [
2525
"CMakeLists.txt"
2626
],
27-
"prerelease": true,
28-
"release-as": "0.1.0",
29-
"bump-minor-pre-major": true
27+
"release-as": "1.0.0"
3028
},
3129
"libs/server-sent-events": {
3230
"initial-version": "0.1.0"

0 commit comments

Comments
 (0)