chore: Address more todo. (#115)

Author: kinyoklion

libs/client-sdk/src/data_sources/data_source_status_manager.hpp

@@ -60,16 +60,14 @@ class DataSourceStatusManager : public IDataSourceStatusProvider {
      */
     void SetError(DataSourceStatus::ErrorInfo::ErrorKind kind,
                   std::string message);
-    // TODO: Handle interrupted and other error states when they are
-    // propagated from the event source.
 
     /**
      * Set an error based on the given status code.
      * @param code The status code of the error.
      */
     void SetError(DataSourceStatus::ErrorInfo::StatusCodeType code,
                   std::string message);
-    // TODO: Handle error codes once the EventSource supports it.
+    // TODO: Handle error codes once the EventSource supports it. sc-204392
 
     DataSourceStatus Status() override;
 

libs/client-sdk/src/data_sources/polling_data_source.cpp

@@ -30,8 +30,6 @@ static network::HttpRequest MakeRequest(
     auto string_context =
         boost::json::serialize(boost::json::value_from(context));
 
-    // TODO: Handle slashes.
-
     network::HttpRequest::BodyType body;
     network::HttpMethod method = network::HttpMethod::kGet;
 
@@ -49,7 +47,6 @@ static network::HttpRequest MakeRequest(
     }
 
     if (data_source_config.with_reasons) {
-        // TODO: Handle better.
         if (url) {
             url->append("?withReasons=true");
         }

libs/client-sdk/src/data_sources/streaming_data_source.cpp

@@ -79,7 +79,7 @@ void StreamingDataSource::Start() {
         return;
     }
 
-    // TODO: Initial reconnect delay.
+    // TODO: Initial reconnect delay. sc-204393
     boost::urls::url url = uri_components.value();
 
     if (data_source_config_.with_reasons) {
@@ -109,7 +109,7 @@ void StreamingDataSource::Start() {
         client_builder.header(header.first, header.second);
     }
 
-    // TODO: Handle proxy support.
+    // TODO: Handle proxy support. sc-204386
 
     auto weak_self = weak_from_this();
 
@@ -118,7 +118,7 @@ void StreamingDataSource::Start() {
             self->data_source_handler_.HandleMessage(event.type(),
                                                      event.data());
             // TODO: Use the result of handle message to restart the
-            // event source if we got bad data.
+            // event source if we got bad data. sc-204387
         }
     });
 

libs/client-sdk/src/flag_manager/flag_updater.cpp

@@ -27,8 +27,6 @@ void FlagUpdater::Init(Context const& context,
 
     // No need to calculate any changes if nobody is listening to them.
     if (!old_flags.empty() && HasListeners()) {
-        // TODO: Should we send events for ALL of the flags when they
-        // are first added?
         for (auto& new_pair : data) {
             auto existing = old_flags.find(new_pair.first);
             if (existing != old_flags.end()) {

libs/common/include/launchdarkly/attribute_reference.hpp

@@ -11,10 +11,12 @@ namespace launchdarkly {
 
 /**
  *  Represents an attribute name or path expression identifying a value within a
- * [TODO: Context]. This can be used to retrieve a value with [TODO: Get Value],
- * or to identify an attribute or nested value that should be considered private
- * with [TODO: private attribute] (the SDK configuration can also have a list of
- * private attribute references).
+ * launchdarkly::Context. This can be used to retrieve a value with
+ * launchdarkly::Context::Get, or to identify an attribute or nested value that
+ * should be considered private
+ * with launchdarkly::AttributesBuilder<BuilderReturn, BuildType>::SetPrivate or
+ * launchdarkly::AttributesBuilder<BuilderReturn, BuildType>::AddPrivateAttribute
+ * (the SDK configuration can also have a list of private attribute references).
  *
  *  This is represented as a separate type, rather than just a string, so that
  * validation and parsing can be done ahead of time if an attribute reference

libs/common/src/config/app_info_builder.cpp

@@ -70,7 +70,7 @@ std::optional<std::string> AppInfoBuilder::Build() const {
 
     for (auto const& tag : unvalidated) {
         if (!tag.second) {
-            // TODO: Figure out how to report.
+            // TODO: Figure out how to report. sc-204388
         } else {
             validated.push_back(tag.second.value());
         }

libs/internal/src/events/asio_event_processor.cpp

@@ -197,8 +197,6 @@ std::optional<EventBatch> AsioEventProcessor<SDK>::CreateBatch() {
         return std::nullopt;
     }
 
-    // TODO(cwaldren): Template the event processor over SDK type? Add it into
-    // HttpProperties?
     config::shared::builders::HttpPropertiesBuilder<config::shared::ClientSDK>
         props(http_props_);