make run() post to sessions' executor; rename to async_connect

Author: cwaldren-ld

contract-tests/sse-contract-tests/src/entity_manager.cpp

@@ -53,7 +53,7 @@ std::optional<std::string> EntityManager::create(ConfigParams const& params) {
         return std::nullopt;
     }
 
-    client->run();
+    client->async_connect();
 
     entities_.emplace(id, std::make_pair(client, poster));
     return id;

libs/client-sdk/src/data_sources/streaming_data_source.cpp

@@ -163,7 +163,7 @@ void StreamingDataSource::Start() {
             kCouldNotParseEndpoint);
         return;
     }
-    client_->run();
+    client_->async_connect();
 }
 
 void StreamingDataSource::ShutdownAsync(std::function<void()> completion) {

libs/server-sent-events/include/launchdarkly/sse/client.hpp

@@ -160,7 +160,7 @@ class Builder {
 class Client {
    public:
     virtual ~Client() = default;
-    virtual void run() = 0;
+    virtual void async_connect() = 0;
     virtual void async_shutdown(std::function<void()> completion) = 0;
 };
 

libs/server-sent-events/src/client.cpp

@@ -175,10 +175,16 @@ class FoxyClient : public Client,
         if (ec == boost::asio::error::operation_aborted) {
             return;
         }
-        run();
+        do_run();
     }
 
-    void run() override {
+    void async_connect() override {
+        boost::asio::post(
+            session_->get_executor(),
+            beast::bind_front_handler(&FoxyClient::do_run, shared_from_this()));
+    }
+
+    void do_run() {
         session_->async_connect(
             host_, port_,
             beast::bind_front_handler(&FoxyClient::on_connect,