feat: replace Encrypted/Plain clients with foxy library (#39)

* add foxy library
* use foxy in both the AsioRequester and Eventsource libraries

Author: cwaldren-ld

CMakeLists.txt

@@ -11,11 +11,6 @@ project(
         LANGUAGES CXX C
 )
 
-if (${CMAKE_VERSION} VERSION_GREATER_EQUAL "3.24")
-    # Affects robustness of timestamp checking on FetchContent dependencies.
-    cmake_policy(SET CMP0135 NEW)
-endif ()
-
 # All projects in this repo should share the same version of 3rd party depends.
 # It's the only way to remain sane.
 set(CMAKE_FILES "${CMAKE_CURRENT_SOURCE_DIR}/cmake")
@@ -36,6 +31,10 @@ if (BUILD_TESTING)
         endif ()
     endif ()
     include(FetchContent)
+    if (${CMAKE_VERSION} VERSION_GREATER_EQUAL "3.24")
+        # Affects robustness of timestamp checking on FetchContent dependencies.
+        cmake_policy(SET CMP0135 NEW)
+    endif ()
     FetchContent_Declare(
             googletest
             URL https://github.com/google/googletest/archive/03597a01ee50ed33e9dfd640b249b4be3799d395.zip

apps/hello-cpp/main.cpp

@@ -60,7 +60,7 @@ int main() {
 
     client.WaitForReadySync(std::chrono::seconds(30));
 
-    auto value = client.BoolVariationDetail("my-bool-flag", false);
+    auto value = client.BoolVariationDetail("my-boolean-flag", false);
     LD_LOG(logger, LogLevel::kInfo) << "Value was: " << *value;
     if (auto reason = value.Reason()) {
         LD_LOG(logger, LogLevel::kInfo) << "Reason was: " << *reason;

apps/sse-contract-tests/src/entity_manager.cpp

@@ -65,6 +65,7 @@ bool EntityManager::destroy(std::string const& id) {
         return false;
     }
 
+    it->second.first->close();
     it->second.second->stop();
 
     entities_.erase(it);

cmake/certify.cmake

@@ -2,6 +2,11 @@ cmake_minimum_required(VERSION 3.11)
 
 include(FetchContent)
 
+if (${CMAKE_VERSION} VERSION_GREATER_EQUAL "3.24")
+    # Affects robustness of timestamp checking on FetchContent dependencies.
+    cmake_policy(SET CMP0135 NEW)
+endif ()
+
 FetchContent_Declare(tl-expected
         GIT_REPOSITORY https://github.com/TartanLlama/expected.git
         GIT_TAG 292eff8bd8ee230a7df1d6a1c00c4ea0eb2f0362

cmake/expected.cmake

@@ -0,0 +1,19 @@
+cmake_minimum_required(VERSION 3.11)
+
+include(FetchContent)
+
+if (${CMAKE_VERSION} VERSION_GREATER_EQUAL "3.24")
+    # Affects robustness of timestamp checking on FetchContent dependencies.
+    cmake_policy(SET CMP0135 NEW)
+endif ()
+
+
+FetchContent_Declare(foxy
+        GIT_REPOSITORY https://github.com/launchdarkly/foxy.git
+        GIT_TAG 7f4ac0495ad2ed9cd0eca5994743d677ac1d2636
+        )
+
+
+set(BUILD_TESTING OFF)
+FetchContent_MakeAvailable(foxy)
+set(BUILD_TESTING ON)

cmake/foxy.cmake

@@ -4,8 +4,13 @@ include(FetchContent)
 
 set(JSON_ImplicitConversions OFF)
 
+if (${CMAKE_VERSION} VERSION_GREATER_EQUAL "3.24")
+    # Affects robustness of timestamp checking on FetchContent dependencies.
+    cmake_policy(SET CMP0135 NEW)
+endif ()
+
 FetchContent_Declare(json
-    URL https://github.com/nlohmann/json/releases/download/v3.11.2/json.tar.xz
-)
+        URL https://github.com/nlohmann/json/releases/download/v3.11.2/json.tar.xz
+        )
 
 FetchContent_MakeAvailable(json)

cmake/json.cmake

@@ -90,6 +90,15 @@ StreamingDataSource::StreamingDataSource(
 
     auto& http_properties = config.HttpProperties();
 
+    // TODO: can the read timeout be shared with *all* http requests? Or should
+    // it have a default in defaults.hpp? This must be greater than the
+    // heartbeat interval of the streaming service.
+    client_builder.read_timeout(std::chrono::minutes(5));
+
+    client_builder.write_timeout(http_properties.WriteTimeout());
+
+    client_builder.connect_timeout(http_properties.ConnectTimeout());
+
     client_builder.header("authorization", config.SdkKey());
     for (auto const& header : http_properties.BaseHeaders()) {
         client_builder.header(header.first, header.second);

libs/client-sdk/src/data_sources/streaming_data_source.cpp

@@ -37,7 +37,7 @@ message(STATUS "LaunchDarkly: using Boost v${Boost_VERSION}")
 
 
 include(${CMAKE_FILES}/expected.cmake)
-include(${CMAKE_FILES}/certify.cmake)
+include(${CMAKE_FILES}/foxy.cmake)
 
 # Add main SDK sources.
 add_subdirectory(src)

libs/common/CMakeLists.txt

@@ -58,6 +58,16 @@ class HttpPropertiesBuilder {
      */
     HttpPropertiesBuilder& ReadTimeout(std::chrono::milliseconds read_timeout);
 
+    /**
+     * Set a write timeout. This is how long it takes to perform a write
+     * operation.
+     *
+     * @param read_timeout The write timeout.
+     * @return A reference to this builder.
+     */
+    HttpPropertiesBuilder& WriteTimeout(
+        std::chrono::milliseconds write_timeout);
+
     /**
      * The time for the first byte to be received during a read. If a byte
      * is not received within this time, then the request will be cancelled.
@@ -115,6 +125,7 @@ class HttpPropertiesBuilder {
    private:
     std::chrono::milliseconds connect_timeout_;
     std::chrono::milliseconds read_timeout_;
+    std::chrono::milliseconds write_timeout_;
     std::chrono::milliseconds response_timeout_;
     std::string wrapper_name_;
     std::string wrapper_version_;

libs/common/include/config/detail/builders/http_properties_builder.hpp

@@ -11,19 +11,23 @@ class HttpProperties final {
    public:
     HttpProperties(std::chrono::milliseconds connect_timeout,
                    std::chrono::milliseconds read_timeout,
+                   std::chrono::milliseconds write_timeout,
                    std::chrono::milliseconds response_timeout,
                    std::string user_agent,
                    std::map<std::string, std::string> base_headers);
 
     [[nodiscard]] std::chrono::milliseconds ConnectTimeout() const;
     [[nodiscard]] std::chrono::milliseconds ReadTimeout() const;
+    [[nodiscard]] std::chrono::milliseconds WriteTimeout() const;
+
     [[nodiscard]] std::chrono::milliseconds ResponseTimeout() const;
     [[nodiscard]] std::string const& UserAgent() const;
     [[nodiscard]] std::map<std::string, std::string> const& BaseHeaders() const;
 
    private:
     std::chrono::milliseconds connect_timeout_;
     std::chrono::milliseconds read_timeout_;
+    std::chrono::milliseconds write_timeout_;
     std::chrono::milliseconds response_timeout_;
     std::string user_agent_;
     std::map<std::string, std::string> base_headers_;

libs/common/include/config/detail/built/http_properties.hpp

@@ -46,14 +46,16 @@ struct Defaults<ClientSDK> {
     }
 
     static auto HttpProperties() -> built::HttpProperties {
-        return {
-            std::chrono::milliseconds{10000}, std::chrono::milliseconds{10000},
-            std::chrono::milliseconds{10000}, SdkName() + "/" + SdkVersion(),
-            std::map<std::string, std::string>()};
+        return {std::chrono::seconds{10},
+                std::chrono::seconds{10},
+                std::chrono::seconds{10},
+                std::chrono::seconds{10},
+                SdkName() + "/" + SdkVersion(),
+                std::map<std::string, std::string>()};
     }
 
     static auto StreamingConfig() -> built::StreamingConfig<ClientSDK> {
-        return {std::chrono::milliseconds{1000}, "/meval"};
+        return {std::chrono::seconds{1}, "/meval"};
     }
 
     static auto DataSourceConfig() -> built::DataSourceConfig<ClientSDK> {
@@ -91,14 +93,16 @@ struct Defaults<ServerSDK> {
     }
 
     static auto HttpProperties() -> built::HttpProperties {
-        return {
-            std::chrono::milliseconds{2000}, std::chrono::milliseconds{10000},
-            std::chrono::milliseconds{10000}, SdkName() + "/" + SdkVersion(),
-            std::map<std::string, std::string>()};
+        return {std::chrono::seconds{2},
+                std::chrono::seconds{10},
+                std::chrono::seconds{10},
+                std::chrono::seconds{10},
+                SdkName() + "/" + SdkVersion(),
+                std::map<std::string, std::string>()};
     }
 
     static auto StreamingConfig() -> built::StreamingConfig<ServerSDK> {
-        return {std::chrono::milliseconds{1000}};
+        return {std::chrono::seconds{1}};
     }
 
     static auto DataSourceConfig() -> built::DataSourceConfig<ServerSDK> {