rename TlsOptions::VerifyMode -> TlsOptions::PeerVerifyMode to get rid of name clash

Author: cwaldren-ld

libs/client-sdk/src/data_sources/polling_data_source.cpp

@@ -74,7 +74,7 @@ PollingDataSource::PollingDataSource(
       status_manager_(status_manager),
       data_source_handler_(
           DataSourceEventHandler(context, handler, logger, status_manager_)),
-      requester_(ioc, http_properties.Tls().VerifyMode()),
+      requester_(ioc, http_properties.Tls().PeerVerifyMode()),
       timer_(ioc),
       polling_interval_(
           std::get<
@@ -88,7 +88,7 @@ PollingDataSource::PollingDataSource(
     auto const& polling_config = std::get<
         config::shared::built::PollingConfig<config::shared::ClientSDK>>(
         data_source_config.method);
-    if (http_properties.Tls().VerifyMode() ==
+    if (http_properties.Tls().PeerVerifyMode() ==
         config::shared::built::TlsOptions::VerifyMode::kVerifyNone) {
         LD_LOG(logger_, LogLevel::kDebug) << "TLS peer verification disabled";
     }

libs/client-sdk/src/data_sources/streaming_data_source.cpp

@@ -127,11 +127,11 @@ void StreamingDataSource::Start() {
         client_builder.header(header.first, header.second);
     }
 
-    if (http_config_.Tls().VerifyMode() ==
+    if (http_config_.Tls().PeerVerifyMode() ==
         config::shared::built::TlsOptions::VerifyMode::kVerifyNone) {
         client_builder.skip_verify_peer(true);
     }
-    
+
     auto weak_self = weak_from_this();
 
     client_builder.receiver([weak_self](launchdarkly::sse::Event const& event) {

libs/common/include/launchdarkly/config/shared/built/http_properties.hpp

@@ -12,10 +12,10 @@ class TlsOptions final {
     enum class VerifyMode { kVerifyPeer, kVerifyNone };
     TlsOptions(VerifyMode verify_mode);
     TlsOptions();
-    [[nodiscard]] VerifyMode VerifyMode() const;
+    [[nodiscard]] VerifyMode PeerVerifyMode() const;
 
    private:
-    enum VerifyMode verify_mode_;
+    VerifyMode verify_mode_;
 };
 
 class HttpProperties final {

libs/common/src/config/http_properties.cpp

@@ -9,7 +9,7 @@ TlsOptions::TlsOptions(enum TlsOptions::VerifyMode verify_mode)
 
 TlsOptions::TlsOptions() : TlsOptions(TlsOptions::VerifyMode::kVerifyPeer) {}
 
-enum TlsOptions::VerifyMode TlsOptions::VerifyMode() const {
+TlsOptions::VerifyMode TlsOptions::PeerVerifyMode() const {
     return verify_mode_;
 }
 
@@ -58,7 +58,7 @@ bool operator==(HttpProperties const& lhs, HttpProperties const& rhs) {
 }
 
 bool operator==(TlsOptions const& lhs, TlsOptions const& rhs) {
-    return lhs.VerifyMode() == rhs.VerifyMode();
+    return lhs.PeerVerifyMode() == rhs.PeerVerifyMode();
 }
 
 }  // namespace launchdarkly::config::shared::built

libs/common/src/config/http_properties_builder.cpp

@@ -11,7 +11,7 @@ TlsBuilder<SDK>::TlsBuilder() : TlsBuilder(shared::Defaults<SDK>::TLS()) {}
 
 template <typename SDK>
 TlsBuilder<SDK>::TlsBuilder(built::TlsOptions const& tls) {
-    verify_mode_ = tls.VerifyMode();
+    verify_mode_ = tls.PeerVerifyMode();
 }
 
 template <typename SDK>

libs/internal/src/events/asio_event_processor.cpp

@@ -47,7 +47,7 @@ AsioEventProcessor<SDK>::AsioEventProcessor(
       workers_(io_,
                events_config.FlushWorkers(),
                events_config.DeliveryRetryDelay(),
-               http_properties.Tls().VerifyMode(),
+               http_properties.Tls().PeerVerifyMode(),
                logger),
       inbox_capacity_(events_config.Capacity()),
       inbox_size_(0),

libs/server-sdk/src/data_systems/background_sync/sources/polling/polling_data_source.cpp

@@ -52,12 +52,12 @@ PollingDataSource::PollingDataSource(
     config::built::HttpProperties const& http_properties)
     : logger_(logger),
       status_manager_(status_manager),
-      requester_(ioc, http_properties.Tls().VerifyMode()),
+      requester_(ioc, http_properties.Tls().PeerVerifyMode()),
       polling_interval_(data_source_config.poll_interval),
       request_(MakeRequest(data_source_config, endpoints, http_properties)),
       timer_(ioc),
       sink_(nullptr) {
-    if (http_properties.Tls().VerifyMode() ==
+    if (http_properties.Tls().PeerVerifyMode() ==
         launchdarkly::config::shared::built::TlsOptions::VerifyMode::
             kVerifyNone) {
         LD_LOG(logger_, LogLevel::kDebug) << "TLS peer verification disabled";

libs/server-sdk/src/data_systems/background_sync/sources/streaming/streaming_data_source.cpp

@@ -104,7 +104,7 @@ void StreamingDataSource::StartAsync(
         client_builder.header(key, value);
     }
 
-    if (http_config_.Tls().VerifyMode() ==
+    if (http_config_.Tls().PeerVerifyMode() ==
         launchdarkly::config::shared::built::TlsOptions::VerifyMode::
             kVerifyNone) {
         client_builder.skip_verify_peer(true);