Skip to content

Commit 60b1b25

Browse files
committed
renaming of VerifyPeer to SkipVerifyPeer
1 parent 5ef3209 commit 60b1b25

File tree

3 files changed

+4
-8
lines changed

3 files changed

+4
-8
lines changed

.github/workflows/client.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ jobs:
3434
# Inform the test harness of test service's port.
3535
test_service_port: ${{ env.TEST_SERVICE_PORT }}
3636
token: ${{ secrets.GITHUB_TOKEN }}
37-
version: 'cw/sc-239174/tls'
3837
build-test:
3938
runs-on: ubuntu-22.04
4039
steps:

contract-tests/client-contract-tests/src/entity_manager.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -131,9 +131,8 @@ std::optional<std::string> EntityManager::create(ConfigParams const& in) {
131131

132132
if (in.tls) {
133133
auto builder = TlsBuilder();
134-
builder.VerifyPeer(!in.tls->skipVerifyPeer);
135-
if (in.tls->certificateAuthorityPath) {
136-
/* TODO: pass in the CA path */
134+
if (in.tls->skipVerifyPeer) {
135+
builder.SkipVerifyPeer(*in.tls->skipVerifyPeer);
137136
}
138137
config_builder.HttpProperties().Tls(std::move(builder));
139138
}

contract-tests/data-model/include/data_model/data_model.hpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,10 @@ struct adl_serializer<std::optional<T>> {
3030
} // namespace nlohmann
3131

3232
struct ConfigTLSParams {
33-
bool skipVerifyPeer;
34-
std::optional<std::string> certificateAuthorityPath;
33+
std::optional<bool> skipVerifyPeer;
3534
};
3635
NLOHMANN_DEFINE_TYPE_NON_INTRUSIVE_WITH_DEFAULT(ConfigTLSParams,
37-
skipVerifyPeer,
38-
certificateAuthorityPath);
36+
skipVerifyPeer);
3937

4038
struct ConfigStreamingParams {
4139
std::optional<std::string> baseUri;

0 commit comments

Comments
 (0)