qol fixes

Author: cwaldren-ld

libs/common/src/events/asio_event_processor.cpp

@@ -175,25 +175,26 @@ std::vector<OutputEvent> AsioEventProcessor::Process(InputEvent input_event) {
                        if (!event.eval_result.track_events()) {
                            return;
                        }
-                       std::optional<Reason> reason;
 
                        // TODO(cwaldren): should also add the reason if the
                        // variation method was VariationDetail().
+                       std::optional<Reason> reason;
                        if (event.eval_result.track_reason()) {
                            reason = event.eval_result.detail().reason();
                        }
 
                        client::FeatureEventBase base = {
-                           event.creation_date, std::move(event.key),
+                           event.creation_date,
+                           std::move(event.key),
                            event.eval_result.version(),
                            event.eval_result.detail().variation_index(),
-                           event.eval_result.detail().value(), reason,
-                           // TODO(cwaldren): change to actual default; figure
-                           // out where this should be plumbed through.
-                           Value::null()};
+                           event.eval_result.detail().value(),
+                           reason,
+                           std::move(event.default_)};
 
                        auto debug_until_date =
                            event.eval_result.debug_events_until_date();
+
                        bool emit_debug_event =
                            debug_until_date &&
                            debug_until_date.value() >

libs/common/src/serialization/events/json_events.cpp

@@ -89,24 +89,11 @@ void tag_invoke(boost::json::value_from_tag const& tag,
 namespace launchdarkly::events::detail {
 void tag_invoke(boost::json::value_from_tag const&,
                 boost::json::value& json_value,
-                Summarizer::VariationSummary const& state) {}
-
-/*
- * version (number, optional): the value of version for the counter; if version
-has no value, this property should be omitted entirely rather than writing a
-null value.
-
-variation (number, optional): the value of variation for the counter; if
-variation has no value, this property should be omitted entirely rather than
-writing a null value.
-
-value (any JSON type): the value of value for the counter.
-
-count (number, required): the value of count for the counter.
+                Summarizer::VariationSummary const& state) {
+    // todo(cwaldren): refactor the serialization out of the Summarizer:State
+    // into here.
+}
 
-unknown (boolean, optional): this should be true if version has no value;
-otherwise it should be omitted (do not write an explicit false).
- */
 void tag_invoke(boost::json::value_from_tag const&,
                 boost::json::value& json_value,
                 Summarizer::State const& state) {