Skip to content

Commit 69c1ece

Browse files
committed
fix a failure to rename
1 parent 41425af commit 69c1ece

File tree

2 files changed

+10
-14
lines changed

2 files changed

+10
-14
lines changed

libs/common/include/config/detail/hosts_builder.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ template <typename SDK>
1818
bool operator==(HostsBuilder<SDK> const& lhs, HostsBuilder<SDK> const& rhs);
1919

2020
/**
21-
* EndpointsBuilder allows for specification of LaunchDarkly service endpoints.
21+
* HostsBuilder allows for specification of LaunchDarkly service hosts.
2222
*
2323
* @tparam SDK Type of SDK, such as ClientSDK or ServerSDK.
2424
*/
@@ -28,7 +28,7 @@ class HostsBuilder {
2828
friend bool operator==
2929
<SDK>(HostsBuilder<SDK> const& lhs, HostsBuilder<SDK> const& rhs);
3030
/**
31-
* Constructs an EndpointsBuilder.
31+
* Constructs an HostsBuilder.
3232
*/
3333
HostsBuilder() = default;
3434

libs/common/tests/event_processor_test.cpp

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,43 +6,39 @@
66
#include "console_backend.hpp"
77
#include "context_builder.hpp"
88
#include "events/detail/asio_event_processor.hpp"
9-
#include "null_logger.hpp"
9+
1010
using namespace launchdarkly;
1111
class EventProcessorTests : public ::testing::Test {};
1212

13-
TEST_F(EventProcessorTests, thing) {
13+
// This test is a temporary test that exists only to ensure the event processor
14+
// compiles; it should be replaced by more robust tests (and contract tests.)
15+
TEST_F(EventProcessorTests, ProcessorCompiles) {
1416
Logger logger{std::make_unique<ConsoleBackend>(LogLevel::kDebug, "test")};
1517
boost::asio::io_context io;
1618

1719
auto config = client::EventsBuilder()
1820
.capacity(10)
19-
.flush_interval(std::chrono::seconds(3))
21+
.flush_interval(std::chrono::seconds(1))
2022
.build();
2123

2224
auto endpoints = client::HostsBuilder().build();
2325

2426
events::detail::AsioEventProcessor ep(io.get_executor(), *config,
2527
*endpoints, "password", logger);
26-
27-
std::thread t([&]() {
28-
io.run();
29-
std::cout << "exiting";
30-
});
31-
std::this_thread::sleep_for(std::chrono::seconds(2));
28+
std::thread t([&]() { io.run(); });
3229

3330
auto c = launchdarkly::ContextBuilder().kind("org", "ld").build();
3431
ASSERT_TRUE(c.valid());
32+
3533
auto ev = events::client::IdentifyEventParams{
3634
std::chrono::system_clock::now(),
3735
c,
3836
};
3937

40-
for (std::size_t i = 0; i < 3; i++) {
38+
for (std::size_t i = 0; i < 10; i++) {
4139
ep.AsyncSend(ev);
4240
}
4341

44-
std::this_thread::sleep_for(std::chrono::seconds(2));
45-
4642
ep.AsyncClose();
4743
t.join();
4844
}

0 commit comments

Comments
 (0)