fix lints

Author: cwaldren-ld

libs/common/src/events/client_events.cpp

@@ -8,7 +8,6 @@ FeatureEventBase::FeatureEventBase(FeatureEventParams const& params)
       variation(params.eval_result.detail().variation_index()),
       value(params.eval_result.detail().value()),
       default_(params.default_) {
-
     // TODO(cwaldren): should also add the reason if the
     // variation method was VariationDetail().
     if (params.eval_result.track_reason()) {

libs/common/src/serialization/events/json_events.cpp

@@ -80,8 +80,9 @@ void tag_invoke(boost::json::value_from_tag const& tag,
 void tag_invoke(boost::json::value_from_tag const& tag,
                 boost::json::value& json_value,
                 events::OutputEvent const& event) {
-    std::visit([&](auto const& e) mutable { tag_invoke(tag, json_value, e); },
-               event);
+    std::visit(
+        [&](auto const& event) mutable { tag_invoke(tag, json_value, event); },
+        event);
 }
 
 }  // namespace launchdarkly::events

libs/common/tests/event_processor_test.cpp

@@ -24,7 +24,7 @@ TEST(EventProcessorTests, ProcessorCompiles) {
     using namespace launchdarkly;
 
     Logger logger{std::make_unique<ConsoleBackend>(LogLevel::kDebug, "test")};
-    boost::asio::io_context io;
+    boost::asio::io_context ioc;
 
     auto config = client::EventsBuilder()
                       .capacity(10)
@@ -33,21 +33,21 @@ TEST(EventProcessorTests, ProcessorCompiles) {
 
     auto endpoints = client::Endpoints().build();
 
-    events::detail::AsioEventProcessor ep(io.get_executor(), *config,
-                                          *endpoints, "password", logger);
-    std::thread t([&]() { io.run(); });
+    events::detail::AsioEventProcessor processor(
+        ioc.get_executor(), *config, *endpoints, "password", logger);
+    std::thread ioc_thread([&]() { ioc.run(); });
 
-    auto c = launchdarkly::ContextBuilder().kind("org", "ld").build();
-    ASSERT_TRUE(c.valid());
+    auto context = launchdarkly::ContextBuilder().kind("org", "ld").build();
+    ASSERT_TRUE(context.valid());
 
-    auto ev = events::client::IdentifyEventParams{
+    auto identify_event = events::client::IdentifyEventParams{
         std::chrono::system_clock::now(),
-        c,
+        context,
     };
 
     for (std::size_t i = 0; i < 10; i++) {
-        ep.AsyncSend(ev);
+        processor.AsyncSend(identify_event);
     }
-    ep.AsyncClose();
-    t.join();
+    processor.AsyncClose();
+    ioc_thread.join();
 }

libs/common/tests/event_summarizer_test.cpp

@@ -107,7 +107,7 @@ TEST_P(SummaryCounterTestsFixture, EventsAreCounted) {
     }
 }
 
-INSTANTIATE_TEST_CASE_P(
+INSTANTIATE_TEST_SUITE_P(
     SummaryCounterTests,
     SummaryCounterTestsFixture,
     ::testing::Values(