rename VerifyPeer to SkipVerifyPeer

Author: cwaldren-ld

libs/client-sdk/include/launchdarkly/client_side/bindings/c/config/builder.h

@@ -422,17 +422,19 @@ LD_EXPORT(void)
 LDClientHttpPropertiesTlsBuilder_Free(LDClientHttpPropertiesTlsBuilder b);
 
 /**
- * Configures TLS peer certificate verification. Enabled by default.
+ * Configures TLS peer certificate verification. Peer verification
+ * is enabled by default.
  *
  * Disabling peer verification is not recommended unless a specific
  * use-case calls for it.
  *
  * @param b Client config builder. Must not be NULL.
- * @param verify_peer True to verify peer, false otherwise.
+ * @param skip_verify_peer False to skip verification.
  */
 LD_EXPORT(void)
-LDClientHttpPropertiesTlsBuilder_VerifyPeer(LDClientHttpPropertiesTlsBuilder b,
-                                            bool verify_peer);
+LDClientHttpPropertiesTlsBuilder_SkipVerifyPeer(
+    LDClientHttpPropertiesTlsBuilder b,
+    bool skip_verify_peer);
 
 /**
  * Disables the default SDK logging.

libs/client-sdk/src/bindings/c/builder.cpp

@@ -324,11 +324,12 @@ LDClientConfigBuilder_HttpProperties_Tls(
 }
 
 LD_EXPORT(void)
-LDClientHttpPropertiesTlsBuilder_VerifyPeer(LDClientHttpPropertiesTlsBuilder b,
-                                            bool verify_peer) {
+LDClientHttpPropertiesTlsBuilder_SkipVerifyPeer(
+    LDClientHttpPropertiesTlsBuilder b,
+    bool skip_verify_peer) {
     LD_ASSERT_NOT_NULL(b);
 
-    TO_TLS_BUILDER(b)->VerifyPeer(verify_peer);
+    TO_TLS_BUILDER(b)->SkipVerifyPeer(skip_verify_peer);
 }
 
 LD_EXPORT(LDClientHttpPropertiesTlsBuilder)

libs/client-sdk/tests/client_config_test.cpp

@@ -81,7 +81,7 @@ TEST(ClientConfigBindings, AllConfigs) {
 
     LDClientHttpPropertiesTlsBuilder tls_builder =
         LDClientHttpPropertiesTlsBuilder_New();
-    LDClientHttpPropertiesTlsBuilder_VerifyPeer(tls_builder, false);
+    LDClientHttpPropertiesTlsBuilder_SkipVerifyPeer(tls_builder, false);
     LDClientConfigBuilder_HttpProperties_Tls(builder, tls_builder);
 
     LDClientHttpPropertiesTlsBuilder tls_builder2 =

libs/common/include/launchdarkly/config/shared/builders/http_properties_builder.hpp

@@ -34,11 +34,11 @@ class TlsBuilder {
     TlsBuilder(built::TlsOptions const& tls);
 
     /**
-     * Whether the remote peer's certificates should be verified.
-     * @param verify_peer True to verify peer, false otherwise.
+     * Whether to skip verifying the remote peer's certificates.
+     * @param verify_peer True to skip verification, false to verify.
      * @return A reference to this builder.
      */
-    TlsBuilder& VerifyPeer(bool verify_peer);
+    TlsBuilder& SkipVerifyPeer(bool skip_verify_peer);
 
     /**
      * Builds the TLS options.

libs/common/src/config/http_properties_builder.cpp

@@ -15,9 +15,10 @@ TlsBuilder<SDK>::TlsBuilder(built::TlsOptions const& tls) {
 }
 
 template <typename SDK>
-TlsBuilder<SDK>& TlsBuilder<SDK>::VerifyPeer(bool verify_peer) {
-    verify_mode_ = verify_peer ? built::TlsOptions::VerifyMode::kVerifyPeer
-                               : built::TlsOptions::VerifyMode::kVerifyNone;
+TlsBuilder<SDK>& TlsBuilder<SDK>::SkipVerifyPeer(bool skip_verify_peer) {
+    verify_mode_ = skip_verify_peer
+                       ? built::TlsOptions::VerifyMode::kVerifyNone
+                       : built::TlsOptions::VerifyMode::kVerifyPeer;
     return *this;
 }