File tree Expand file tree Collapse file tree 6 files changed +18
-14
lines changed
client-sdk/include/launchdarkly/client_side
common/include/launchdarkly Expand file tree Collapse file tree 6 files changed +18
-14
lines changed Original file line number Diff line number Diff line change @@ -21,6 +21,11 @@ namespace launchdarkly::client_side {
21
21
*/
22
22
class IClient {
23
23
public:
24
+ /* *
25
+ * Represents the key of a feature flag.
26
+ */
27
+ using FlagKey = std::string;
28
+
24
29
/* * Connects the client to LaunchDarkly's flag delivery endpoints.
25
30
*
26
31
* If StartAsync isn't called, the client is able to post events but is
@@ -49,14 +54,13 @@ class IClient {
49
54
[[nodiscard]] virtual bool Initialized () const = 0;
50
55
51
56
/* *
52
- * Returns a map from feature flag keys to <see cref="LdValue"/> feature
57
+ * Returns a map from feature flag keys to feature
53
58
* flag values for the current context.
54
59
*
55
60
* This method will not send analytics events back to LaunchDarkly.
56
61
*
57
- * @return a map from feature flag keys to values for the current context
62
+ * @return A map from feature flag keys to values for the current context.
58
63
*/
59
- using FlagKey = std::string;
60
64
[[nodiscard]] virtual std::unordered_map<FlagKey, Value> AllFlags ()
61
65
const = 0;
62
66
Original file line number Diff line number Diff line change @@ -184,7 +184,7 @@ class DataSourceBuilder<ServerSDK> {
184
184
* @param stream_builder The streaming builder.
185
185
* @return Reference to this builder.
186
186
*/
187
- DataSourceBuilder& Method (Streaming builder );
187
+ DataSourceBuilder& Method (Streaming stream_builder );
188
188
189
189
/* *
190
190
* Set the polling configuration for the builder.
@@ -196,7 +196,7 @@ class DataSourceBuilder<ServerSDK> {
196
196
* @param polling_builder The polling builder.
197
197
* @return Reference to this builder.
198
198
*/
199
- DataSourceBuilder& Method (Polling builder );
199
+ DataSourceBuilder& Method (Polling polling_builder );
200
200
201
201
/* *
202
202
* Build a data source config. This is used internal to the SDK.
Original file line number Diff line number Diff line change @@ -86,8 +86,8 @@ class EventsBuilder {
86
86
* necessary to call either of these methods, as the default behavior is to
87
87
* treat all attributes as non-private unless otherwise specified.
88
88
*
89
- * @param value True for behavior of (1), false for default behavior of (2)
90
- * or (3).
89
+ * @param all_attributes_private True for behavior of (1), false for default
90
+ * behavior of (2) or (3).
91
91
* @return Reference to this builder.
92
92
*/
93
93
EventsBuilder& AllAttributesPrivate (bool all_attributes_private);
Original file line number Diff line number Diff line change @@ -61,7 +61,7 @@ class HttpPropertiesBuilder {
61
61
* Set a write timeout. This is how long it takes to perform a Write
62
62
* operation.
63
63
*
64
- * @param read_timeout The write timeout.
64
+ * @param write_timeout The write timeout.
65
65
* @return A reference to this builder.
66
66
*/
67
67
HttpPropertiesBuilder& WriteTimeout (
Original file line number Diff line number Diff line change @@ -32,8 +32,8 @@ class Events final {
32
32
* private or not.
33
33
* @param private_attrs Which attributes should be treated as private, if
34
34
* AllAttributesPrivate is false.
35
- * @param security Whether a plaintext or encrypted client should be used
36
- * for event delivery .
35
+ * @param delivery_retry_delay How long to wait before a redelivery attempt
36
+ * should be made .
37
37
* @param flush_workers How many workers to use for concurrent event
38
38
* delivery.
39
39
*/
Original file line number Diff line number Diff line change @@ -37,11 +37,11 @@ class IPersistence {
37
37
*
38
38
* @param storage_namespace The namespace for the data.
39
39
* @param key The key for the data.
40
- * @param value The data to add or update.
40
+ * @param data The data to add or update.
41
41
*/
42
42
virtual void Set (std::string storage_namespace,
43
- std::string key,
44
- std::string data) noexcept = 0;
43
+ std::string key,
44
+ std::string data) noexcept = 0;
45
45
46
46
/* *
47
47
* Remove a value from the store. If the value cannot be removed, then
@@ -51,7 +51,7 @@ class IPersistence {
51
51
* @param key The key of the data.
52
52
*/
53
53
virtual void Remove (std::string storage_namespace,
54
- std::string key) noexcept = 0;
54
+ std::string key) noexcept = 0;
55
55
56
56
/* *
57
57
* Attempt to read a value from the store.
You can’t perform that action at this time.
0 commit comments