Skip to content

Commit 9547f86

Browse files
authored
chore: fix some misnamed parameters in doxygen comments (#126)
1 parent 8201e17 commit 9547f86

File tree

6 files changed

+18
-14
lines changed

6 files changed

+18
-14
lines changed

libs/client-sdk/include/launchdarkly/client_side/client.hpp

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,11 @@ namespace launchdarkly::client_side {
2121
*/
2222
class IClient {
2323
public:
24+
/**
25+
* Represents the key of a feature flag.
26+
*/
27+
using FlagKey = std::string;
28+
2429
/** Connects the client to LaunchDarkly's flag delivery endpoints.
2530
*
2631
* If StartAsync isn't called, the client is able to post events but is
@@ -49,14 +54,13 @@ class IClient {
4954
[[nodiscard]] virtual bool Initialized() const = 0;
5055

5156
/**
52-
* Returns a map from feature flag keys to <see cref="LdValue"/> feature
57+
* Returns a map from feature flag keys to feature
5358
* flag values for the current context.
5459
*
5560
* This method will not send analytics events back to LaunchDarkly.
5661
*
57-
* @return a map from feature flag keys to values for the current context
62+
* @return A map from feature flag keys to values for the current context.
5863
*/
59-
using FlagKey = std::string;
6064
[[nodiscard]] virtual std::unordered_map<FlagKey, Value> AllFlags()
6165
const = 0;
6266

libs/common/include/launchdarkly/config/shared/builders/data_source_builder.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ class DataSourceBuilder<ServerSDK> {
184184
* @param stream_builder The streaming builder.
185185
* @return Reference to this builder.
186186
*/
187-
DataSourceBuilder& Method(Streaming builder);
187+
DataSourceBuilder& Method(Streaming stream_builder);
188188

189189
/**
190190
* Set the polling configuration for the builder.
@@ -196,7 +196,7 @@ class DataSourceBuilder<ServerSDK> {
196196
* @param polling_builder The polling builder.
197197
* @return Reference to this builder.
198198
*/
199-
DataSourceBuilder& Method(Polling builder);
199+
DataSourceBuilder& Method(Polling polling_builder);
200200

201201
/**
202202
* Build a data source config. This is used internal to the SDK.

libs/common/include/launchdarkly/config/shared/builders/events_builder.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,8 @@ class EventsBuilder {
8686
* necessary to call either of these methods, as the default behavior is to
8787
* treat all attributes as non-private unless otherwise specified.
8888
*
89-
* @param value True for behavior of (1), false for default behavior of (2)
90-
* or (3).
89+
* @param all_attributes_private True for behavior of (1), false for default
90+
* behavior of (2) or (3).
9191
* @return Reference to this builder.
9292
*/
9393
EventsBuilder& AllAttributesPrivate(bool all_attributes_private);

libs/common/include/launchdarkly/config/shared/builders/http_properties_builder.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ class HttpPropertiesBuilder {
6161
* Set a write timeout. This is how long it takes to perform a Write
6262
* operation.
6363
*
64-
* @param read_timeout The write timeout.
64+
* @param write_timeout The write timeout.
6565
* @return A reference to this builder.
6666
*/
6767
HttpPropertiesBuilder& WriteTimeout(

libs/common/include/launchdarkly/config/shared/built/events.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ class Events final {
3232
* private or not.
3333
* @param private_attrs Which attributes should be treated as private, if
3434
* AllAttributesPrivate is false.
35-
* @param security Whether a plaintext or encrypted client should be used
36-
* for event delivery.
35+
* @param delivery_retry_delay How long to wait before a redelivery attempt
36+
* should be made.
3737
* @param flush_workers How many workers to use for concurrent event
3838
* delivery.
3939
*/

libs/common/include/launchdarkly/persistence/persistence.hpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,11 @@ class IPersistence {
3737
*
3838
* @param storage_namespace The namespace for the data.
3939
* @param key The key for the data.
40-
* @param value The data to add or update.
40+
* @param data The data to add or update.
4141
*/
4242
virtual void Set(std::string storage_namespace,
43-
std::string key,
44-
std::string data) noexcept = 0;
43+
std::string key,
44+
std::string data) noexcept = 0;
4545

4646
/**
4747
* Remove a value from the store. If the value cannot be removed, then
@@ -51,7 +51,7 @@ class IPersistence {
5151
* @param key The key of the data.
5252
*/
5353
virtual void Remove(std::string storage_namespace,
54-
std::string key) noexcept = 0;
54+
std::string key) noexcept = 0;
5555

5656
/**
5757
* Attempt to read a value from the store.

0 commit comments

Comments
 (0)