fix more lints

Author: cwaldren-ld

libs/common/include/events/detail/summarizer.hpp

@@ -30,7 +30,7 @@ class Summarizer {
      * Construct a Summarizer at time zero.
      */
     Summarizer() = default;
-
+    
     /**
      * Updates the summary with a feature event.
      * @param event Feature event.
@@ -40,7 +40,7 @@ class Summarizer {
     /**
      * Returns true if the summary is empty.
      */
-    bool Empty() const;
+    [[nodiscard]] bool Empty() const;
 
     /**
      * Returns the summary's start time as given in the constructor.
@@ -51,20 +51,20 @@ class Summarizer {
        public:
         explicit VariationSummary(Value value);
         void Increment();
-        std::size_t count() const;
-        Value const& value() const;
+        [[nodiscard]] std::int32_t count() const;
+        [[nodiscard]] Value const& value() const;
 
        private:
-        std::size_t count_;
+        std::int32_t count_;
         Value value_;
     };
 
     struct VariationKey {
         std::optional<Version> version;
         std::optional<VariationIndex> variation;
-        VariationKey(Version version, std::optional<VariationIndex> variation);
 
         VariationKey();
+        VariationKey(Version version, std::optional<VariationIndex> variation);
 
         bool operator==(VariationKey const& k) const {
             return k.variation == variation && k.version == version;

libs/common/include/serialization/events/json_events.hpp

@@ -40,13 +40,11 @@ void tag_invoke(boost::json::value_from_tag const&,
 }  // namespace launchdarkly::events
 
 namespace launchdarkly::events::detail {
-void tag_invoke(boost::json::value_from_tag const&,
-                boost::json::value& json_value,
-                Summarizer::VariationSummary const& state);
+
 void tag_invoke(boost::json::value_from_tag const&,
                 boost::json::value& json_value,
                 Summarizer::State const& state);
 void tag_invoke(boost::json::value_from_tag const&,
                 boost::json::value& json_value,
-                Summary const& summarizer);
+                Summary const& summary);
 }  // namespace launchdarkly::events::detail

libs/common/src/events/summarizer.cpp

@@ -68,18 +68,17 @@ Summarizer::VariationSummary::VariationSummary(Value value)
     : count_(0), value_(std::move(value)) {}
 
 void Summarizer::VariationSummary::Increment() {
-    // todo(cwaldren): prevent overflow?
     count_++;
 }
 
 Value const& Summarizer::VariationSummary::value() const {
     return value_;
 }
 
-std::size_t Summarizer::VariationSummary::count() const {
+std::int32_t Summarizer::VariationSummary::count() const {
     return count_;
 }
 
 Summarizer::State::State(Value default_value)
-    : default_(std::move(default_value)), context_kinds() {}
+    : default_(std::move(default_value)) {}
 }  // namespace launchdarkly::events::detail

libs/common/src/serialization/events/json_events.cpp

@@ -23,7 +23,7 @@ void tag_invoke(boost::json::value_from_tag const& tag,
     json_value = std::move(base);
 }
 
-void tag_invoke(boost::json::value_from_tag const&,
+void tag_invoke(boost::json::value_from_tag const& tag,
                 boost::json::value& json_value,
                 FeatureEventBase const& event) {
     auto& obj = json_value.emplace_object();
@@ -40,7 +40,7 @@ void tag_invoke(boost::json::value_from_tag const&,
     obj.emplace("default", boost::json::value_from(event.default_));
 }
 
-void tag_invoke(boost::json::value_from_tag const&,
+void tag_invoke(boost::json::value_from_tag const& tag,
                 boost::json::value& json_value,
                 IdentifyEvent const& event) {
     auto& obj = json_value.emplace_object();
@@ -52,7 +52,7 @@ void tag_invoke(boost::json::value_from_tag const&,
 
 namespace launchdarkly::events {
 
-void tag_invoke(boost::json::value_from_tag const&,
+void tag_invoke(boost::json::value_from_tag const& tag,
                 boost::json::value& json_value,
                 Date const& date) {
     json_value.emplace_int64() =
@@ -61,7 +61,7 @@ void tag_invoke(boost::json::value_from_tag const&,
             .count();
 }
 
-void tag_invoke(boost::json::value_from_tag const&,
+void tag_invoke(boost::json::value_from_tag const& tag,
                 boost::json::value& json_value,
                 TrackEvent const& event) {
     auto& obj = json_value.emplace_object();
@@ -87,14 +87,8 @@ void tag_invoke(boost::json::value_from_tag const& tag,
 }  // namespace launchdarkly::events
 
 namespace launchdarkly::events::detail {
-void tag_invoke(boost::json::value_from_tag const&,
-                boost::json::value& json_value,
-                Summarizer::VariationSummary const& state) {
-    // todo(cwaldren): refactor the serialization out of the Summarizer:State
-    // into here.
-}
 
-void tag_invoke(boost::json::value_from_tag const&,
+void tag_invoke(boost::json::value_from_tag const& tag,
                 boost::json::value& json_value,
                 Summarizer::State const& state) {
     auto& obj = json_value.emplace_object();
@@ -117,14 +111,15 @@ void tag_invoke(boost::json::value_from_tag const&,
     }
     obj.emplace("counters", std::move(counters));
 }
-void tag_invoke(boost::json::value_from_tag const&,
+void tag_invoke(boost::json::value_from_tag const& tag,
                 boost::json::value& json_value,
-                Summary const& s) {
+                Summary const& summary) {
     auto& obj = json_value.emplace_object();
     obj.emplace("kind", "summary");
     obj.emplace("startDate",
-                boost::json::value_from(Date{s.summarizer.start_time()}));
-    obj.emplace("endDate", boost::json::value_from(Date{s.end_time}));
-    obj.emplace("features", boost::json::value_from(s.summarizer.features()));
+                boost::json::value_from(Date{summary.summarizer.start_time()}));
+    obj.emplace("endDate", boost::json::value_from(Date{summary.end_time}));
+    obj.emplace("features",
+                boost::json::value_from(summary.summarizer.features()));
 }
 }  // namespace launchdarkly::events::detail