use simplest solution

Author: cwaldren-ld

examples/hello-cpp-client/main.cpp

@@ -62,19 +62,6 @@ int main() {
     std::cout << "*** Feature flag '" << FEATURE_FLAG_KEY << "' is "
               << (flag_value ? "true" : "false") << " for this user\n\n";
 
-    for (int i = 0; i < 5; i++) {
-        auto user_key = "example-user-key-" + std::to_string(i);
-        auto context2 =
-            ContextBuilder().Kind("user", user_key).Name("Bob").Build();
-
-        std::cout << "identifying " << user_key << std::endl;
-        auto fut = client.IdentifyAsync(context2);
-        fut.wait();
-        std::cout << "identified " << user_key << "!" << std::endl;
-
-        std::this_thread::sleep_for(std::chrono::seconds(5));
-    }
-
     return 0;
 }
 

libs/server-sent-events/src/client.cpp

@@ -340,8 +340,28 @@ class FoxyClient : public Client,
         shutting_down_ = true;
         // If any backoff is taking place, cancel that as well.
         backoff_timer_.cancel();
-        
-        boost::system::error_code ec = {};
+
+        // Cancels the outstanding read.
+        if (session_->stream.is_ssl()) {
+            session_->stream.ssl().next_layer().cancel();
+        } else {
+            session_->stream.plain().cancel();
+        }
+
+        // Ideally we would call session_->async_shutdown() here to gracefully
+        // terminate the SSL session. For unknown reasons, this call appears to
+        // hang indefinitely and never complete until the SDK client is
+        // destroyed.
+        //
+        // A workaround is to set a timeout on the operation, say 1 second. This
+        // gives the opportunity to shutdown gracefully and then if that fails,
+        // we could close the socket directly. But that also doesn't seem to
+        // work: even with the timeout, the operation still doesn't complete.
+        //
+        // So the most robust solution appears to be closing the socket
+        // directly. This is not ideal because it doesn't send a close_notify to
+        // the server.
+        boost::system::error_code ec;
         session_->stream.plain().shutdown(
             boost::asio::ip::tcp::socket::shutdown_both, ec);
         session_->stream.plain().close(ec);