fix: include query parameters on streaming requests (#97)

I was using the wrong api on `boost::url` - the `path()` doesn't include
query parameters (important for `withReason`!). It's also not encoded,
so wrong on two accounts.

Switched to `encoded_target()`.

Author: cwaldren-ld

apps/sdk-contract-tests/test-suppressions.txt

@@ -1,7 +1,5 @@
 events/summary events/basic counter behavior
 events/summary events/reset after each flush
-streaming/requests/query parameters/evaluationReasons set to true/GET
-streaming/requests/query parameters/evaluationReasons set to true/REPORT
 tags/disallowed characters
 
 # The Client doesn't need to know how to deserialize users.

libs/server-sent-events/src/client.cpp

@@ -58,8 +58,7 @@ class FoxyClient : public Client,
           read_timeout_(read_timeout),
           write_timeout_(write_timeout),
           req_(std::move(req)),
-          body_parser_(),
-          session_(executor,
+          session_(std::move(executor),
                    foxy::session_opts{ToOptRef(ssl_context_),
                                       connect_timeout.value_or(kNoTimeout)}),
           logger_(std::move(logger)) {
@@ -69,7 +68,7 @@ class FoxyClient : public Client,
         body_parser_.get().body().on_event(std::move(receiver));
     }
 
-    void fail(boost::system::error_code ec, std::string what) {
+    void fail(boost::system::error_code ec, std::string const& what) {
         logger_("sse-client: " + what + ": " + ec.message());
         async_shutdown(nullptr);
     }
@@ -83,12 +82,11 @@ class FoxyClient : public Client,
 
     void async_shutdown(std::function<void()> completion) override {
         session_.async_shutdown(beast::bind_front_handler(
-            &FoxyClient::on_shutdown, shared_from_this(),
-            std::move(completion)));
+            &FoxyClient::on_shutdown, std::move(completion)));
     }
 
-    void on_shutdown(std::function<void()> completion,
-                     boost::system::error_code ec) {
+    static void on_shutdown(std::function<void()> completion,
+                            boost::system::error_code ec) {
         boost::ignore_unused(ec);
         if (completion) {
             completion();
@@ -229,15 +227,15 @@ std::shared_ptr<Client> Builder::build() {
 
     auto request = request_;
 
-    // Don't send a body unless the method is POST or REPORT
-    if (!(request.method() == http::verb::post ||
-          request.method() == http::verb::report)) {
+    // If this isn't a post or report, ensure the body is empty.
+    if (request.method() != http::verb::post &&
+        request.method() != http::verb::report) {
         request.body() = "";
     } else {
         // If it is, then setup Content-Type, only if one wasn't
         // specified.
-        if (auto it = request.find(http::field::content_type);
-            it == request.end()) {
+        if (auto content_header = request.find(http::field::content_type);
+            content_header == request.end()) {
             request.set(http::field::content_type, "text/plain");
         }
     }
@@ -247,7 +245,7 @@ std::shared_ptr<Client> Builder::build() {
     std::string host = uri_components->host();
 
     request.set(http::field::host, host);
-    request.target(uri_components->path());
+    request.target(uri_components->encoded_target());
 
     std::string service = uri_components->has_port() ? uri_components->port()
                                                      : uri_components->scheme();