fix: Change notification consistency.

kinyoklion · kinyoklion · commit ebde89af2bd4 · 2025-01-28T09:31:58.000-08:00
The store should be updated before events are dispatched to ensure
consistent data between event information and variation calls.
diff --git a/libs/client-sdk/src/flag_manager/flag_updater.cpp b/libs/client-sdk/src/flag_manager/flag_updater.cpp
@@ -95,6 +95,7 @@ void FlagUpdater::Upsert(Context const& context,
         return;
     }
 
+    flag_store_.Upsert(key, descriptor);
     if (HasListeners()) {
         // Existed and updated.
         if (existing && descriptor.item) {
@@ -112,7 +113,6 @@ void FlagUpdater::Upsert(Context const& context,
             // Do nothing.
         }
     }
-    flag_store_.Upsert(key, descriptor);
 }
 
 bool FlagUpdater::HasListeners() const {

Original file line number	Diff line number	Diff line change
`@@ -95,6 +95,7 @@ void FlagUpdater::Upsert(Context const& context,`
`95`	`95`	`return;`
`96`	`96`	`}`
`97`	`97`
	`98`	`+ flag_store_.Upsert(key, descriptor);`
`98`	`99`	`if (HasListeners()) {`
`99`	`100`	`// Existed and updated.`
`100`	`101`	`if (existing && descriptor.item) {`
`@@ -112,7 +113,6 @@ void FlagUpdater::Upsert(Context const& context,`
`112`	`113`	`// Do nothing.`
`113`	`114`	`}`
`114`	`115`	`}`
`115`		`- flag_store_.Upsert(key, descriptor);`
`116`	`116`	`}`
`117`	`117`
`118`	`118`	`bool FlagUpdater::HasListeners() const {`