fix: handle service endpoints with custom ports correctly (#389)

Users can configure the SDK with custom service endpoints. There was a
bug in the endpoint configuration process where using a custom port
would mean you couldn't also specify a HTTPS connection.

That is, if you specified something like `https://localhost:9090` for
testing, it would see `9090` and not setup the proper SSL context
needed. This had no affect on default usage of the SDK, because the
default LaunchDarkly endpoints don't specify a port.

Author: cwaldren-ld

libs/internal/include/launchdarkly/network/asio_requester.hpp

@@ -323,7 +323,7 @@ class AsioRequester {
                 request->Port().value_or(request->Https() ? "https" : "http");
 
             std::shared_ptr<ssl::context> ssl;
-            if (service == "https") {
+            if (request->Https()) {
                 ssl = this->ssl_ctx_;
             }
 

libs/server-sent-events/src/client.cpp

@@ -589,11 +589,22 @@ std::shared_ptr<Client> Builder::build() {
     request.set(http::field::host, host);
     request.target(uri_components->encoded_target());
 
+    if (uri_components->has_scheme()) {
+        if (!(uri_components->scheme_id() == boost::urls::scheme::http ||
+              uri_components->scheme_id() == boost::urls::scheme::https)) {
+            return nullptr;
+        }
+    }
+
+    // The resolver accepts either a port number or a service name. If the
+    // URL specifies a port, use that - otherwise, pass in the scheme as the
+    // service name (which will be either http or https due to the check
+    // above.)
     std::string service = uri_components->has_port() ? uri_components->port()
                                                      : uri_components->scheme();
 
     std::optional<ssl::context> ssl;
-    if (service == "https") {
+    if (uri_components->scheme_id() == boost::urls::scheme::https) {
         ssl = launchdarkly::foxy::make_ssl_ctx(ssl::context::tlsv12_client);
         ssl->set_default_verify_paths();
     }