Skip to content

chore: Add string.h dependency to hello-cpp-client. #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 30, 2023
Merged

chore: Add string.h dependency to hello-cpp-client. #118

merged 3 commits into from
May 30, 2023

Conversation

kinyoklion
Copy link
Member

No description provided.

@kinyoklion kinyoklion requested a review from cwaldren-ld May 25, 2023 22:45
@cwaldren-ld
Copy link
Contributor

cwaldren-ld commented May 30, 2023 •
edited
Loading

inclusion of deprecated C++ header 'string.h'; consider using 'cstring' instead

Seems legit, otherwise looks good

@kinyoklion kinyoklion merged commit ddaa897 into main May 30, 2023
@kinyoklion kinyoklion deleted the kinyoklion-patch-1 branch May 30, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwaldren-ld cwaldren-ld cwaldren-ld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kinyoklion @cwaldren-ld