Skip to content

Commit 5f41e70

Browse files
Remove hpo methods (aws#39)
1 parent 684d6a9 commit 5f41e70

File tree

2 files changed

+1
-39
lines changed

2 files changed

+1
-39
lines changed

src/sagemaker/amazon/hyperparameter.py

Lines changed: 1 addition & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@
1212
# language governing permissions and limitations under the License.
1313
from __future__ import absolute_import
1414

15-
from sagemaker.tuner import _ParameterRange
16-
1715

1816
class Hyperparameter(object):
1917
"""An algorithm hyperparameter with optional validation. Implemented as a python
@@ -48,35 +46,12 @@ def validate(self, value):
4846
raise ValueError(error_message)
4947

5048
def __get__(self, obj, objtype):
51-
"""Return the value of this hyperparameter, whether it be a range or one discrete value"""
52-
if '_parameter_ranges' in dir(obj) and self.name in obj._parameter_ranges:
53-
return obj._parameter_ranges[self.name]
5449
if '_hyperparameters' not in dir(obj) or self.name not in obj._hyperparameters:
5550
raise AttributeError()
5651
return obj._hyperparameters[self.name]
5752

5853
def __set__(self, obj, value):
59-
"""Assign values for hyperparameters"""
60-
if isinstance(value, _ParameterRange):
61-
self._set_parameter_range(obj, value)
62-
else:
63-
self._set_hyperparameter(obj, value)
64-
65-
def _set_parameter_range(self, obj, value):
66-
# remove from the hyperparameters if it's there
67-
if '_hyperparameters' in dir(obj) and self.name in obj._hyperparameters:
68-
del obj._hyperparameters[self.name]
69-
70-
if '_parameter_ranges' not in dir(obj):
71-
obj._parameter_ranges = dict()
72-
obj._parameter_ranges[self.name] = value
73-
74-
def _set_hyperparameter(self, obj, value):
7554
"""Validate the supplied value and set this hyperparameter to value"""
76-
# remove from the parameter_ranges if it's there
77-
if '_parameter_ranges' in dir(obj) and self.name in obj._parameter_ranges:
78-
del obj._parameter_ranges[self.name]
79-
8055
value = None if value is None else self.data_type(value)
8156
self.validate(value)
8257
if '_hyperparameters' not in dir(obj):
@@ -85,10 +60,7 @@ def _set_hyperparameter(self, obj, value):
8560

8661
def __delete__(self, obj):
8762
"""Delete this hyperparameter"""
88-
if '_hyperparameters' in dir(obj) and self.name in obj._hyperparameters:
89-
del obj._hyperparameters[self.name]
90-
if '_parameter_ranges' in dir(obj) and self.name in obj._parameter_ranges:
91-
del obj._parameter_ranges[self.name]
63+
del obj._hyperparameters[self.name]
9264

9365
@staticmethod
9466
def serialize_all(obj):

tests/unit/test_hyperparameter.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414

1515
import pytest
1616
from sagemaker.amazon.hyperparameter import Hyperparameter
17-
from sagemaker.tuner import ContinuousParameter
1817

1918

2019
class Test(object):
@@ -75,12 +74,3 @@ def test_from_string():
7574

7675
x.validated = from_api
7776
assert x.validated == value
78-
79-
80-
def test_delete_parameter_range():
81-
x = Test()
82-
x.validated = ContinuousParameter(0, 5)
83-
del(x.validated)
84-
85-
with pytest.raises(AttributeError):
86-
x.validated

0 commit comments

Comments
 (0)