Skip to content

Commit c159f38

Browse files
dpkpchandlernine
authored andcommitted
Do not block on sender thread join after timeout in producer.close() (dpkp#1974)
1 parent bddf777 commit c159f38

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

kafka/producer/kafka.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -452,7 +452,7 @@ def __getattr__(self, name):
452452
global log
453453
log = NullLogger()
454454

455-
self.close(timeout=0)
455+
self.close()
456456

457457
def close(self, timeout=None):
458458
"""Close this producer.
@@ -491,14 +491,10 @@ def close(self, timeout=None):
491491
self._sender.join(timeout)
492492

493493
if self._sender is not None and self._sender.is_alive():
494-
495494
log.info("Proceeding to force close the producer since pending"
496495
" requests could not be completed within timeout %s.",
497496
timeout)
498497
self._sender.force_close()
499-
# Only join the sender thread when not calling from callback.
500-
if not invoked_from_callback:
501-
self._sender.join()
502498

503499
self._metrics.close()
504500
try:

0 commit comments

Comments
 (0)