Skip to content

Commit a695eaa

Browse files
committed
Revert "Updated MachinePassReg and added some passes"
This reverts commit 5290f20.
1 parent 1e6bb9a commit a695eaa

File tree

2 files changed

+1
-46
lines changed

2 files changed

+1
-46
lines changed

llvm/include/llvm/Passes/CodeGenPassBuilder.h

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,6 @@
1414
#ifndef LLVM_PASSES_CODEGENPASSBUILDER_H
1515
#define LLVM_PASSES_CODEGENPASSBUILDER_H
1616

17-
#include "llvm/Transforms/Scalar/SeparateConstOffsetFromGEP.h"
18-
#include "llvm/Transforms/Scalar/StraightLineStrengthReduce.h"
19-
#include "llvm/Transforms/Scalar/NaryReassociate.h"
20-
#include "llvm/Transforms/Scalar/GVN.h"
21-
#include "llvm/MC/MCStreamer.h"
22-
2317
#include "llvm/ADT/SmallVector.h"
2418
#include "llvm/ADT/StringRef.h"
2519
#include "llvm/Analysis/AliasAnalysis.h"
@@ -411,11 +405,6 @@ template <typename DerivedT> class CodeGenPassBuilder {
411405
/// before exception handling preparation passes.
412406
void addCodeGenPrepare(AddIRPass &) const;
413407

414-
/// TODO: Add description
415-
void addStraightLineScalarOptimizationPasses(AddIRPass &) const;
416-
417-
void addEarlyCSEOrGVNPass(AddIRPass &) const;
418-
419408
/// Add common passes that perform LLVM IR to IR transforms in preparation for
420409
/// instruction selection.
421410
void addISelPrepare(AddIRPass &) const;
@@ -684,31 +673,6 @@ void CodeGenPassBuilder<Derived>::addIRPasses(AddIRPass &addPass) const {
684673
addPass(SelectOptimizePass(&TM));
685674
}
686675

687-
template <typename Derived>
688-
void CodeGenPassBuilder<Derived>::addEarlyCSEOrGVNPass(AddIRPass &addPass) const {
689-
if (getOptLevel() == CodeGenOptLevel::Aggressive)
690-
addPass(GVNPass());
691-
else
692-
addPass(EarlyCSEPass());
693-
}
694-
695-
template <typename Derived>
696-
void CodeGenPassBuilder<Derived>::addStraightLineScalarOptimizationPasses(AddIRPass &addPass) const {
697-
addPass(SeparateConstOffsetFromGEPPass());
698-
// ReassociateGEPs exposes more opportunities for SLSR. See
699-
// the example in reassociate-geps-and-slsr.ll.
700-
addPass(StraightLineStrengthReducePass());
701-
// SeparateConstOffsetFromGEP and SLSR creates common expressions which GVN or
702-
// EarlyCSE can reuse.
703-
// FIXME: Port this
704-
addEarlyCSEOrGVNPass(addPass);
705-
// Run NaryReassociate after EarlyCSE/GVN to be more effective.
706-
addPass(NaryReassociatePass());
707-
// NaryReassociate on GEPs creates redundant common expressions, so run
708-
// EarlyCSE after it.
709-
addPass(EarlyCSEPass());
710-
}
711-
712676
/// Turn exception handling constructs into something the code generators can
713677
/// handle.
714678
template <typename Derived>

llvm/include/llvm/Passes/MachinePassRegistry.def

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -53,22 +53,18 @@ FUNCTION_PASS("expand-large-fp-convert", ExpandLargeFpConvertPass(TM))
5353
FUNCTION_PASS("expand-memcmp", ExpandMemCmpPass(TM))
5454
FUNCTION_PASS("expand-reductions", ExpandReductionsPass())
5555
FUNCTION_PASS("expandvp", ExpandVectorPredicationPass())
56-
FUNCTION_PASS("gvn", GVNPass())
5756
FUNCTION_PASS("gc-lowering", GCLoweringPass())
5857
FUNCTION_PASS("indirectbr-expand", IndirectBrExpandPass(TM))
5958
FUNCTION_PASS("interleaved-access", InterleavedAccessPass(TM))
6059
FUNCTION_PASS("interleaved-load-combine", InterleavedLoadCombinePass(TM))
6160
FUNCTION_PASS("lower-constant-intrinsics", LowerConstantIntrinsicsPass())
6261
FUNCTION_PASS("lower-invoke", LowerInvokePass())
6362
FUNCTION_PASS("mergeicmps", MergeICmpsPass())
64-
FUNCTION_PASS("nary-reassociate", NaryReassociatePass())
6563
FUNCTION_PASS("partially-inline-libcalls", PartiallyInlineLibCallsPass())
6664
FUNCTION_PASS("post-inline-ee-instrument", EntryExitInstrumenterPass(true))
6765
FUNCTION_PASS("replace-with-veclib", ReplaceWithVeclib())
6866
FUNCTION_PASS("safe-stack", SafeStackPass(TM))
6967
FUNCTION_PASS("scalarize-masked-mem-intrin", ScalarizeMaskedMemIntrinPass())
70-
FUNCTION_PASS("separate-const-offset-from-gep", SeparateConstOffsetFromGEPPass())
71-
FUNCTION_PASS("slsr", StraightLineStrengthReducePass())
7268
FUNCTION_PASS("select-optimize", SelectOptimizePass(TM))
7369
FUNCTION_PASS("sjlj-eh-prepare", SjLjEHPreparePass(TM))
7470
FUNCTION_PASS("stack-protector", StackProtectorPass(TM))
@@ -77,8 +73,6 @@ FUNCTION_PASS("unreachableblockelim", UnreachableBlockElimPass())
7773
FUNCTION_PASS("verify", VerifierPass())
7874
FUNCTION_PASS("wasm-eh-prepare", WasmEHPreparePass())
7975
FUNCTION_PASS("win-eh-prepare", WinEHPreparePass())
80-
FUNCTION_PASS("load-store-vectorizer", LoadStoreVectorizerPass())
81-
FUNCTION_PASS("lowerswitch", LowerSwitchPass())
8276
#undef FUNCTION_PASS
8377

8478
#ifndef LOOP_PASS
@@ -130,7 +124,7 @@ MACHINE_FUNCTION_ANALYSIS("pass-instrumentation", PassInstrumentationAnalysis(PI
130124
#define MACHINE_FUNCTION_PASS(NAME, CREATE_PASS)
131125
#endif
132126
MACHINE_FUNCTION_PASS("dead-mi-elimination", DeadMachineInstructionElimPass())
133-
MACHINE_FUNCTION_PASS("free-machine-function", FreeMachineFunctionPass())
127+
// MACHINE_FUNCTION_PASS("free-machine-function", FreeMachineFunctionPass())
134128
MACHINE_FUNCTION_PASS("no-op-machine-function", NoOpMachineFunctionPass())
135129
MACHINE_FUNCTION_PASS("print", PrintMIRPass())
136130
#undef MACHINE_FUNCTION_PASS
@@ -143,7 +137,6 @@ MACHINE_FUNCTION_PASS("print", PrintMIRPass())
143137
#define DUMMY_FUNCTION_PASS(NAME, PASS_NAME)
144138
#endif
145139
DUMMY_FUNCTION_PASS("atomic-expand", AtomicExpandPass)
146-
DUMMY_FUNCTION_PASS("early-cse", EarlyCSEPass)
147140
#undef DUMMY_FUNCTION_PASS
148141

149142
#ifndef DUMMY_MACHINE_MODULE_PASS
@@ -164,7 +157,6 @@ DUMMY_MACHINE_FUNCTION_PASS("bbsections-profile-reader", BasicBlockSectionsProfi
164157
DUMMY_MACHINE_FUNCTION_PASS("block-placement", MachineBlockPlacementPass)
165158
DUMMY_MACHINE_FUNCTION_PASS("block-placement-stats", MachineBlockPlacementStatsPass)
166159
DUMMY_MACHINE_FUNCTION_PASS("branch-folder", BranchFolderPass)
167-
DUMMY_MACHINE_FUNCTION_PASS("branch-relaxation", BranchRelaxationPass)
168160
DUMMY_MACHINE_FUNCTION_PASS("break-false-deps", BreakFalseDepsPass)
169161
DUMMY_MACHINE_FUNCTION_PASS("cfguard-longjmp", CFGuardLongjmpPass)
170162
DUMMY_MACHINE_FUNCTION_PASS("cfi-fixup", CFIFixupPass)
@@ -207,7 +199,6 @@ DUMMY_MACHINE_FUNCTION_PASS("opt-phis", OptimizePHIsPass)
207199
DUMMY_MACHINE_FUNCTION_PASS("patchable-function", PatchableFunctionPass)
208200
DUMMY_MACHINE_FUNCTION_PASS("peephole-opt", PeepholeOptimizerPass)
209201
DUMMY_MACHINE_FUNCTION_PASS("phi-node-elimination", PHIEliminationPass)
210-
DUMMY_MACHINE_FUNCTION_PASS("post-RA-hazard-recognizer", PostRAHazardRecognizerPass)
211202
DUMMY_MACHINE_FUNCTION_PASS("post-RA-sched", PostRASchedulerPass)
212203
DUMMY_MACHINE_FUNCTION_PASS("postmisched", PostMachineSchedulerPass)
213204
DUMMY_MACHINE_FUNCTION_PASS("postra-machine-sink", PostRAMachineSinkingPass)

0 commit comments

Comments
 (0)