Make Branches.Move() accept a Branch as its target

Author: nulltoken

LibGit2Sharp.Tests/BranchFixture.cs

@@ -319,6 +319,18 @@ public void CanGetTrackingInformationForLocalTrackingBranch()
             }
         }
 
+        [Fact]
+        public void MovingARemoteTrackingBranchThrows()
+        {
+            using (var repo = new Repository(StandardTestRepoPath))
+            {
+                Branch master = repo.Branches["refs/remotes/origin/master"];
+                Assert.True(master.IsRemote);
+
+                Assert.Throws<LibGit2SharpException>(() => repo.Branches.Move(master, "new_name", true));
+            }
+        }
+
         [Fact]
         public void CanWalkCommitsFromAnotherBranch()
         {

LibGit2Sharp/BranchCollection.cs

@@ -215,7 +215,7 @@ public virtual void Delete(string name, bool isRemote = false)
         }
 
         /// <summary>
-        ///   Rename an existing local branch with a new name.
+        ///   Renames an existing local branch with a new name.
         /// </summary>
         /// <param name = "currentName">The current branch name.</param>
         /// <param name = "newName">The new name the existing branch should bear.</param>
@@ -231,6 +231,26 @@ public virtual Branch Move(string currentName, string newName, bool allowOverwri
             return this[newName];
         }
 
+        /// <summary>
+        ///   Renames an existing local branch with a new name.
+        /// </summary>
+        /// <param name = "branch">The current local branch.</param>
+        /// <param name = "newName">The new name the existing branch should bear.</param>
+        /// <param name = "allowOverwrite">True to allow silent overwriting a potentially existing branch, false otherwise.</param>
+        /// <returns>A new <see cref="Branch"/>.</returns>
+        public virtual Branch Move(Branch branch, string newName, bool allowOverwrite = false)
+        {
+            Ensure.ArgumentNotNull(branch, "branch");
+            Ensure.ArgumentNotNullOrEmptyString(newName, "newName");
+
+            if (branch.IsRemote)
+            {
+                throw new LibGit2SharpException(string.Format("Cannot rename branch '{0}'. It's a remote tracking branch.", branch.Name));
+            }
+
+            return Move(branch.Name, newName, allowOverwrite);
+        }
+
         private static bool LooksLikeABranchName(string referenceName)
         {
             return referenceName == "HEAD" ||