Fix git_status_file binding (GIT_EAMBIGOUS is a valid return value)

Author: yorah

LibGit2Sharp.Tests/StatusFixture.cs

@@ -241,5 +241,23 @@ public void RetrievingTheStatusOfTheRepositoryHonorsTheGitIgnoreDirectives()
                 Assert.Equal(new[] { relativePath, "new_untracked_file.txt" }, newStatus.Ignored);
             }
         }
+
+        [Fact(Skip = "This test needs libgit2/libgit2@ffbc689")]
+        public void RetrievingTheStatusOfAnAmbiguousFileThrows()
+        {
+            TemporaryCloneOfTestRepo path = BuildTemporaryCloneOfTestRepo(StandardTestRepoWorkingDirPath);
+            using (var repo = new Repository(path.RepositoryPath))
+            {
+                string relativePath = Path.Combine("1", "ambiguous1.txt");
+                string fullFilePath = Path.Combine(repo.Info.WorkingDirectory, relativePath);
+                File.WriteAllText(fullFilePath, "I don't like brackets.");
+                
+                relativePath = Path.Combine("1", "ambiguous[1].txt");
+                fullFilePath = Path.Combine(repo.Info.WorkingDirectory, relativePath);
+                File.WriteAllText(fullFilePath, "Brackets all the way.");
+
+                repo.Index.RetrieveStatus(relativePath);
+            }
+        }
     }
 }

LibGit2Sharp/Core/Proxy.cs

@@ -1284,13 +1284,19 @@ public static FileStatus git_status_file(RepositorySafeHandle repo, FilePath pat
                 FileStatus status;
                 int res = NativeMethods.git_status_file(out status, repo, path);
 
-                if (res == (int)GitErrorCode.NotFound)
+                switch (res)
                 {
-                    return FileStatus.Nonexistent;
+                    case (int)GitErrorCode.NotFound:
+                        return FileStatus.Nonexistent;
+                    
+                    case (int)GitErrorCode.Ambiguous:
+                        throw new AmbiguousException(string.Format(CultureInfo.InvariantCulture, "More than one file matches the pathspec '{0}'. You can either force a literal path evaluation (GIT_STATUS_OPT_DISABLE_PATHSPEC_MATCH), or use git_status_foreach().", path));
+   
+                    default:
+                        Ensure.Success(res);
+                        break;
                 }
 
-                Ensure.Success(res);
-
                 return status;
             }
         }