fixup! fixup! fixup! fixup! Allow the caller to inspect the host's certificate

Author: carlosmn

LibGit2Sharp.Tests/CloneFixture.cs

@@ -250,28 +250,25 @@ public void CanInspectCertificateOnClone(string url, string hostname, Type certT
                 "SSH not supported");
 
             bool wasCalled = false;
+            bool checksHappy = false;
 
-
-            Repository.Clone(url, scd.DirectoryPath, new CloneOptions
-            {
-                CertificateCheck = (cert, valid, host) =>
-                {
+            var options = new CloneOptions {
+                CertificateCheck = (cert, valid, host) => {
                     wasCalled = true;
 
                     Assert.Equal(hostname, host);
                     Assert.Equal(certType, cert.GetType());
 
-                    if (certType == typeof(CertificateX509))
-                    {
+                    if (certType == typeof(CertificateX509)) {
                         Assert.True(valid);
                         var x509 = ((CertificateX509)cert).Certificate;
                         // we get a string with the different fields instead of a structure, so...
                         Assert.True(x509.Subject.Contains("CN=github.com,"));
-                        return true;
+                        checksHappy = true;
+                        return false;
                     }
 
-                    if (certType == typeof(CertificateSsh))
-                    {
+                    if (certType == typeof(CertificateSsh)) {
                         var hostkey = (CertificateSsh)cert;
                         Assert.True(hostkey.HasMD5);
                         /*
@@ -283,15 +280,21 @@ public void CanInspectCertificateOnClone(string url, string hostname, Type certT
                          * though GitHub's hostkey won't change anytime soon.
                          */
                         Assert.Equal("1627aca576282d36631b564debdfa648",
-                                BitConverter.ToString(hostkey.HashMD5).ToLower().Replace("-", ""));
-                        return true;
+                            BitConverter.ToString(hostkey.HashMD5).ToLower().Replace("-", ""));
+                        checksHappy = true;
+                        return false;
                     }
 
                     return false;
                 },
-            });
+            };
+
+            Assert.Throws<UserCancelledException>(() =>
+                Repository.Clone(url, scd.DirectoryPath, options)
+            );
 
             Assert.True(wasCalled);
+            Assert.True(checksHappy);
         }
 
         [Fact]