Revert "Make Tags.Add() accept an ObjectId as its target"

This reverts commit 34c4aac.

Author: nulltoken

LibGit2Sharp.Tests/TagFixture.cs

@@ -30,19 +30,6 @@ public void CanAddALightWeightTagFromSha()
             }
         }
 
-        [Fact]
-        public void CanAddALightWeightTagFromObjectId()
-        {
-            TemporaryCloneOfTestRepo path = BuildTemporaryCloneOfTestRepo();
-            using (var repo = new Repository(path.RepositoryPath))
-            {
-                Tag newTag = repo.Tags.Add("i_am_lightweight", new ObjectId(commitE90810BSha));
-                Assert.NotNull(newTag);
-                Assert.False(newTag.IsAnnotated);
-                Assert.Equal(commitE90810BSha, newTag.Target.Sha);
-            }
-        }
-
         [Fact]
         public void CanAddALightWeightTagFromAGitObject()
         {
@@ -167,19 +154,6 @@ public void CanAddAnAnnotatedTagFromSha()
             }
         }
 
-        [Fact]
-        public void CanAddAnAnnotatedTagFromObjectId()
-        {
-            TemporaryCloneOfTestRepo path = BuildTemporaryCloneOfTestRepo();
-            using (var repo = new Repository(path.RepositoryPath))
-            {
-                Tag newTag = repo.Tags.Add("unit_test", new ObjectId(tagTestSha), signatureTim, "a new tag");
-                Assert.NotNull(newTag);
-                Assert.True(newTag.IsAnnotated);
-                Assert.Equal(tagTestSha, newTag.Target.Sha);
-            }
-        }
-
         [Fact]
         public void CanAddAnAnnotatedTagFromObject()
         {
@@ -521,7 +495,6 @@ public void AddTagWithNullTargetThrows()
             {
                 Assert.Throws<ArgumentNullException>(() => repo.Tags.Add("test_tag", (GitObject)null, signatureTim, "message"));
                 Assert.Throws<ArgumentNullException>(() => repo.Tags.Add("test_tag", (string)null, signatureTim, "message"));
-                Assert.Throws<ArgumentNullException>(() => repo.Tags.Add("test_tag", (ObjectId)null, signatureTim, "message"));
             }
         }
 

LibGit2Sharp/TagCollection.cs

@@ -69,37 +69,6 @@ IEnumerator IEnumerable.GetEnumerator()
 
         #endregion
 
-        /// <summary>
-        ///   Creates an annotated tag with the specified name.
-        /// </summary>
-        /// <param name = "name">The name.</param>
-        /// <param name = "targetId">Id of the target object.</param>
-        /// <param name = "tagger">The tagger.</param>
-        /// <param name = "message">The message.</param>
-        /// <param name = "allowOverwrite">True to allow silent overwriting a potentially existing tag, false otherwise.</param>
-        /// <returns></returns>
-        public virtual Tag Add(string name, ObjectId targetId, Signature tagger, string message, bool allowOverwrite = false)
-        {
-            Ensure.ArgumentNotNullOrEmptyString(name, "name");
-            Ensure.ArgumentNotNull(targetId, "targetId");
-            Ensure.ArgumentNotNull(tagger, "tagger");
-            Ensure.ArgumentNotNull(message, "message");
-
-            string prettifiedMessage = ObjectDatabase.PrettifyMessage(message);
-
-            int res;
-            using (var objectPtr = new ObjectSafeWrapper(targetId, repo))
-            using (SignatureSafeHandle taggerHandle = tagger.BuildHandle())
-            {
-                GitOid oid;
-                res = NativeMethods.git_tag_create(out oid, repo.Handle, name, objectPtr.ObjectPtr, taggerHandle, prettifiedMessage, allowOverwrite);
-            }
-
-            Ensure.Success(res);
-
-            return this[name];
-        }
-
         /// <summary>
         ///   Creates an annotated tag with the specified name.
         /// </summary>
@@ -179,30 +148,6 @@ public virtual Tag Add(string name, GitObject target, bool allowOverwrite = fals
             return this[name];
         }
 
-        /// <summary>
-        ///   Creates a lightweight tag with the specified name.
-        /// </summary>
-        /// <param name = "name">The name.</param>
-        /// <param name = "targetId">Id of the target object.</param>
-        /// <param name = "allowOverwrite">True to allow silent overwriting a potentially existing tag, false otherwise.</param>
-        /// <returns></returns>
-        public virtual Tag Add(string name, ObjectId targetId, bool allowOverwrite = false)
-        {
-            Ensure.ArgumentNotNullOrEmptyString(name, "name");
-            Ensure.ArgumentNotNull(targetId, "targetId");
-
-            int res;
-            using (var objectPtr = new ObjectSafeWrapper(targetId, repo))
-            {
-                GitOid oid;
-                res = NativeMethods.git_tag_create_lightweight(out oid, repo.Handle, name, objectPtr.ObjectPtr, allowOverwrite);
-            }
-
-            Ensure.Success(res);
-
-            return this[name];
-        }
-
         /// <summary>
         ///   Creates a lightweight tag with the specified name.
         /// </summary>

LibGit2Sharp/TagCollectionExtensions.cs

@@ -22,7 +22,7 @@ public static Tag Add(this TagCollection tags, string name, string objectish, Si
 
             GitObject objectToTag = tags.repo.Lookup(objectish, GitObjectType.Any, LookUpOptions.ThrowWhenNoGitObjectHasBeenFound);
 
-            return tags.Add(name, objectToTag.Id, tagger, message, allowOverwrite);
+            return tags.Add(name, objectToTag, tagger, message, allowOverwrite);
         }
 
         /// <summary>
@@ -38,7 +38,7 @@ public static Tag Add(this TagCollection tags, string name, string objectish, bo
 
             GitObject objectToTag = tags.repo.Lookup(objectish, GitObjectType.Any, LookUpOptions.ThrowWhenNoGitObjectHasBeenFound);
 
-            return tags.Add(name, objectToTag.Id, allowOverwrite);
+            return tags.Add(name, objectToTag, allowOverwrite);
         }
     }
 }