Skip to content

Commit 494de48

Browse files
shiftkeynulltoken
authored andcommitted
Drop optional parameters in TagCollection
1 parent e1e5fe6 commit 494de48

File tree

1 file changed

+26
-2
lines changed

1 file changed

+26
-2
lines changed

LibGit2Sharp/TagCollection.cs

Lines changed: 26 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,19 @@ IEnumerator IEnumerable.GetEnumerator()
6969

7070
#endregion
7171

72+
/// <summary>
73+
/// Creates an annotated tag with the specified name.
74+
/// </summary>
75+
/// <param name="name">The name.</param>
76+
/// <param name="target">The target <see cref="GitObject"/>.</param>
77+
/// <param name="tagger">The tagger.</param>
78+
/// <param name="message">The message.</param>
79+
/// <returns>The added <see cref="Tag"/>.</returns>
80+
public virtual Tag Add(string name, GitObject target, Signature tagger, string message)
81+
{
82+
return Add(name, target, tagger, message, false);
83+
}
84+
7285
/// <summary>
7386
/// Creates an annotated tag with the specified name.
7487
/// </summary>
@@ -78,7 +91,7 @@ IEnumerator IEnumerable.GetEnumerator()
7891
/// <param name="message">The message.</param>
7992
/// <param name="allowOverwrite">True to allow silent overwriting a potentially existing tag, false otherwise.</param>
8093
/// <returns>The added <see cref="Tag"/>.</returns>
81-
public virtual Tag Add(string name, GitObject target, Signature tagger, string message, bool allowOverwrite = false)
94+
public virtual Tag Add(string name, GitObject target, Signature tagger, string message, bool allowOverwrite)
8295
{
8396
Ensure.ArgumentNotNullOrEmptyString(name, "name");
8497
Ensure.ArgumentNotNull(target, "target");
@@ -92,14 +105,25 @@ public virtual Tag Add(string name, GitObject target, Signature tagger, string m
92105
return this[name];
93106
}
94107

108+
/// <summary>
109+
/// Creates a lightweight tag with the specified name.
110+
/// </summary>
111+
/// <param name="name">The name.</param>
112+
/// <param name="target">The target <see cref="GitObject"/>.</param>
113+
/// <returns>The added <see cref="Tag"/>.</returns>
114+
public virtual Tag Add(string name, GitObject target)
115+
{
116+
return Add(name, target, false);
117+
}
118+
95119
/// <summary>
96120
/// Creates a lightweight tag with the specified name.
97121
/// </summary>
98122
/// <param name="name">The name.</param>
99123
/// <param name="target">The target <see cref="GitObject"/>.</param>
100124
/// <param name="allowOverwrite">True to allow silent overwriting a potentially existing tag, false otherwise.</param>
101125
/// <returns>The added <see cref="Tag"/>.</returns>
102-
public virtual Tag Add(string name, GitObject target, bool allowOverwrite = false)
126+
public virtual Tag Add(string name, GitObject target, bool allowOverwrite)
103127
{
104128
Ensure.ArgumentNotNullOrEmptyString(name, "name");
105129
Ensure.ArgumentNotNull(target, "target");

0 commit comments

Comments
 (0)