Fix Commit() so that it always updates the HEAD

Fix #692

Author: mumitroller

LibGit2Sharp.Tests/RepositoryOptionsFixture.cs

@@ -1,5 +1,6 @@
 using System;
 using System.IO;
+using System.Linq;
 using System.Text;
 using LibGit2Sharp.Tests.TestHelpers;
 using Xunit;
@@ -174,5 +175,38 @@ public void CanProvideDifferentConfigurationFilesToARepository()
 
             AssertValueInConfigFile(systemLocation, "xpaulbettsx");
         }
+
+        [Fact]
+        public void CanCommitOnBareRepository()
+        {
+            string repoPath = InitNewRepository(true);
+            SelfCleaningDirectory scd = BuildSelfCleaningDirectory();
+            string workPath = Path.Combine(scd.RootedDirectoryPath, "work");
+            Directory.CreateDirectory(workPath);
+
+            var repositoryOptions = new RepositoryOptions
+            {
+                WorkingDirectoryPath = workPath,
+                IndexPath = Path.Combine(scd.RootedDirectoryPath, "index")
+            };
+
+            using (var repo = new Repository(repoPath, repositoryOptions))
+            {
+                const string relativeFilepath = "test.txt";
+                Touch(repo.Info.WorkingDirectory, relativeFilepath, "test\n");
+                repo.Index.Stage(relativeFilepath);
+
+                Assert.NotNull(repo.Commit("Initial commit", Constants.Signature, Constants.Signature));
+                Assert.Equal(1, repo.Head.Commits.Count());
+                Assert.Equal(1, repo.Commits.Count());
+
+                // However, as we're in a bare repository, by default core.logallrefupdates is unset
+                Assert.Null(repo.Config.Get<bool>("core.logallrefupdates"));
+
+                // TODO: Uncomment these lines once this is handled at the libgit2 level
+                //Assert.Equal(0, repo.Refs.Log("refs/heads/master").Count());
+                //Assert.Equal(0, repo.Refs.Log("HEAD").Count());
+            }
+        }
     }
 }

LibGit2Sharp/Repository.cs

@@ -894,12 +894,6 @@ public Commit Commit(string message, Signature author, Signature committer, Comm
 
             Proxy.git_repository_state_cleanup(handle);
 
-            var logAllRefUpdates = Config.GetValueOrDefault<bool>("core.logAllRefUpdates", false);
-            if (!logAllRefUpdates)
-            {
-                return result;
-            }
-
             var logMessage = BuildCommitLogMessage(result, options.AmendPreviousCommit, isHeadOrphaned, parents.Count > 1);
             LogCommit(result, logMessage);