fixup! Allow the caller to inspect the host's certificate

Author: nulltoken

LibGit2Sharp.Tests/CloneFixture.cs

@@ -244,35 +244,43 @@ public void CanInspectCertificateOnClone(string url, string hostname, Type certT
         {
             var scd = BuildSelfCleaningDirectory();
 
-            if (certType == typeof(CertificateSsh) && !GlobalSettings.Version.Features.HasFlag(BuiltInFeatures.Ssh))
-            {
-                throw new SkipException("SSH not supported");
-            }
+            InconclusiveIf(
+                () =>
+                    certType == typeof (CertificateSsh) && !GlobalSettings.Version.Features.HasFlag(BuiltInFeatures.Ssh),
+                "SSH not supported");
+
+            bool wasCalled = false;
+
 
-            Assert.Throws<UserCancelledException>(() => {
-                Repository.Clone(url, scd.DirectoryPath, new CloneOptions()
+            Repository.Clone(url, scd.DirectoryPath, new CloneOptions
+            {
+                CertificateCheck = (cert, valid, host) =>
                 {
-                    CertificateCheck = (cert, valid, host) =>
+                    Assert.Equal(hostname, host);
+                    Assert.Equal(certType, cert.GetType());
+
+                    if (certType == typeof(CertificateX509))
                     {
-                        Assert.Equal(hostname, host);
-                        Assert.Equal(certType, cert.GetType());
-                        if (certType == typeof(CertificateX509))
-                        {
-                            Assert.True(valid);
-                            var x509 = ((CertificateX509)cert).Certificate;
-                            // we get a string with the different fields instead of a structure, so...
-                            Assert.True(x509.Subject.Contains("CN=github.com,"));
-                        }
-                        else
-                        {
-                            var hostkey = (CertificateSsh)cert;
-                            Assert.True(hostkey.HasMD5);
-                            Assert.Equal("1627aca576282d36631b564debdfa648", BitConverter.ToString(hostkey.HashMD5));
-                        }
-                        return false;
-                    },
-                });
+                        Assert.True(valid);
+                        var x509 = ((CertificateX509)cert).Certificate;
+                        // we get a string with the different fields instead of a structure, so...
+                        Assert.True(x509.Subject.Contains("CN=github.com,"));
+                        return true;
+                    }
+
+                    if (certType == typeof(CertificateSsh))
+                    {
+                        var hostkey = (CertificateSsh)cert;
+                        Assert.True(hostkey.HasMD5);
+                        Assert.Equal("1627aca576282d36631b564debdfa648", BitConverter.ToString(hostkey.HashMD5));
+                        return true;
+                    }
+
+                    return false;
+                },
             });
+
+            Assert.True(wasCalled);
         }
 
         [Fact]