Validate ReferenceWrapper ctor reference argument

dahlbyk · dahlbyk · commit 734adf7d69ed · 2012-06-13T22:47:12.000-05:00
diff --git a/LibGit2Sharp/ReferenceWrapper.cs b/LibGit2Sharp/ReferenceWrapper.cs
@@ -25,6 +25,7 @@ public abstract class ReferenceWrapper<TObject> : IEquatable<ReferenceWrapper<TO
         protected internal ReferenceWrapper(Repository repo, Reference reference, Func<Reference, string> canonicalNameSelector)
         {
             Ensure.ArgumentNotNull(repo, "repo");
+            Ensure.ArgumentNotNull(reference, "reference");
             Ensure.ArgumentNotNull(canonicalNameSelector, "canonicalNameSelector");
 
             this.repo = repo;
@@ -71,8 +72,6 @@ protected TObject TargetObject
 
         private TObject RetrieveTargetObject(Reference reference)
         {
-            Ensure.ArgumentNotNull(reference, "reference");
-
             var directReference = reference.ResolveToDirectReference();
             if (directReference == null)
             {

Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,7 @@ public abstract class ReferenceWrapper<TObject> : IEquatable<ReferenceWrapper<TO`
`25`	`25`	`protected internal ReferenceWrapper(Repository repo, Reference reference, Func<Reference, string> canonicalNameSelector)`
`26`	`26`	`{`
`27`	`27`	`Ensure.ArgumentNotNull(repo, "repo");`
	`28`	`+ Ensure.ArgumentNotNull(reference, "reference");`
`28`	`29`	`Ensure.ArgumentNotNull(canonicalNameSelector, "canonicalNameSelector");`
`29`	`30`
`30`	`31`	`this.repo = repo;`
`@@ -71,8 +72,6 @@ protected TObject TargetObject`
`71`	`72`
`72`	`73`	`private TObject RetrieveTargetObject(Reference reference)`
`73`	`74`	`{`
`74`		`- Ensure.ArgumentNotNull(reference, "reference");`
`75`		`-`
`76`	`75`	`var directReference = reference.ResolveToDirectReference();`
`77`	`76`	`if (directReference == null)`
`78`	`77`	`{`