Skip to content

Commit aba6add

Browse files
committed
Don't force filters to have Since
1 parent b0356e6 commit aba6add

File tree

2 files changed

+0
-5
lines changed

2 files changed

+0
-5
lines changed

LibGit2Sharp.Tests/CommitFixture.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ public void QueryingTheCommitHistoryWithUnknownShaOrInvalidEntryPointThrows()
9898
{
9999
Assert.Throws<LibGit2SharpException>(() => repo.Commits.QueryBy(new Filter { Since = Constants.UnknownSha }).Count());
100100
Assert.Throws<LibGit2SharpException>(() => repo.Commits.QueryBy(new Filter { Since = "refs/heads/deadbeef" }).Count());
101-
Assert.Throws<ArgumentNullException>(() => repo.Commits.QueryBy(new Filter { Since = null }).Count());
102101
}
103102
}
104103

@@ -120,8 +119,6 @@ public void QueryingTheCommitHistoryWithBadParamsThrows()
120119
{
121120
using (var repo = new Repository(BareTestRepoPath))
122121
{
123-
Assert.Throws<ArgumentException>(() => repo.Commits.QueryBy(new Filter { Since = string.Empty }));
124-
Assert.Throws<ArgumentNullException>(() => repo.Commits.QueryBy(new Filter { Since = null }));
125122
Assert.Throws<ArgumentNullException>(() => repo.Commits.QueryBy(null));
126123
}
127124
}

LibGit2Sharp/CommitLog.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,6 @@ IEnumerator IEnumerable.GetEnumerator()
8080
public ICommitLog QueryBy(Filter filter)
8181
{
8282
Ensure.ArgumentNotNull(filter, "filter");
83-
Ensure.ArgumentNotNull(filter.Since, "filter.Since");
84-
Ensure.ArgumentNotNullOrEmptyString(filter.Since.ToString(), "filter.Since");
8583

8684
return new CommitLog(repo, filter);
8785
}

0 commit comments

Comments
 (0)