Check Since param if SinceGlob is not specified

Author: tclem

LibGit2Sharp.Tests/CommitFixture.cs

@@ -98,6 +98,7 @@ public void QueryingTheCommitHistoryWithUnknownShaOrInvalidEntryPointThrows()
             {
                 Assert.Throws<LibGit2SharpException>(() => repo.Commits.QueryBy(new Filter { Since = Constants.UnknownSha }).Count());
                 Assert.Throws<LibGit2SharpException>(() => repo.Commits.QueryBy(new Filter { Since = "refs/heads/deadbeef" }).Count());
+                Assert.Throws<ArgumentNullException>(() => repo.Commits.QueryBy(new Filter { Since = null }).Count());
             }
         }
 
@@ -119,6 +120,8 @@ public void QueryingTheCommitHistoryWithBadParamsThrows()
         {
             using (var repo = new Repository(BareTestRepoPath))
             {
+                Assert.Throws<ArgumentException>(() => repo.Commits.QueryBy(new Filter { Since = string.Empty }));
+                Assert.Throws<ArgumentNullException>(() => repo.Commits.QueryBy(new Filter { Since = null }));
                 Assert.Throws<ArgumentNullException>(() => repo.Commits.QueryBy(null));
             }
         }

LibGit2Sharp/CommitLog.cs

@@ -87,6 +87,12 @@ public virtual ICommitLog QueryBy(Filter filter)
         {
             Ensure.ArgumentNotNull(filter, "filter");
 
+            if(string.IsNullOrEmpty(filter.SinceGlob))
+            {
+                Ensure.ArgumentNotNull(filter.Since, "filter.Since");
+                Ensure.ArgumentNotNullOrEmptyString(filter.Since.ToString(), "filter.Since");
+            }
+
             return new CommitLog(repo, filter);
         }