Protect Commit creation from message containing '\0'

Author: nulltoken

LibGit2Sharp.Tests/ObjectDatabaseFixture.cs

@@ -1,5 +1,6 @@
 using System;
 using System.IO;
+using System.Linq;
 using System.Text;
 using LibGit2Sharp.Tests.TestHelpers;
 using Xunit;
@@ -417,5 +418,20 @@ public void CanEnumerateTheGitObjectsFromBareRepository()
                 Assert.True(count >= 1683);
             }
         }
+
+        [Theory]
+        [InlineData("\0Leading zero")]
+        [InlineData("Trailing zero\0")]
+        [InlineData("Zero \0inside")]
+        [InlineData("\0")]
+        [InlineData("\0\0\0")]
+        public void CreatingACommitWithMessageContainingZeroByteThrows(string message)
+        {
+            using (var repo = new Repository(BareTestRepoPath))
+            {
+                Assert.Throws<ArgumentException>(() => repo.ObjectDatabase.CreateCommit(
+                    message, Constants.Signature, Constants.Signature, repo.Head.Tip.Tree, Enumerable.Empty<Commit>()));
+            }
+        }
     }
 }

LibGit2Sharp/ObjectDatabase.cs

@@ -198,6 +198,7 @@ public virtual Commit CreateCommit(string message, Signature author, Signature c
         internal Commit CreateCommit(string message, Signature author, Signature committer, Tree tree, IEnumerable<Commit> parents, string referenceName)
         {
             Ensure.ArgumentNotNull(message, "message");
+            Ensure.ArgumentDoesNotContainZeroByte(message, "message");
             Ensure.ArgumentNotNull(author, "author");
             Ensure.ArgumentNotNull(committer, "committer");
             Ensure.ArgumentNotNull(tree, "tree");