fixup! Allow the caller to inspect the host's certificate

Author: nulltoken

LibGit2Sharp/Certificate.cs

@@ -1,17 +1,9 @@
-using System;
-
-namespace LibGit2Sharp
+namespace LibGit2Sharp
 {
     /// <summary>
     /// Top-level certificate type. The usable certificates inherit from this class.
     /// </summary>
     public abstract class Certificate
     {
-        /// <summary>
-        /// For mocking
-        /// </summary>
-        protected Certificate()
-        { }
     }
 }
-

LibGit2Sharp/CertificateSsh.cs

@@ -1,6 +1,4 @@
-using System;
-using System.Diagnostics;
-using LibGit2Sharp.Core;
+using LibGit2Sharp.Core;
 
 namespace LibGit2Sharp
 {
@@ -9,6 +7,12 @@ namespace LibGit2Sharp
     /// </summary>
     public class CertificateSsh : Certificate
     {
+        /// <summary>
+        /// For mocking purposes
+        /// </summary>
+        protected CertificateSsh()
+        { }
+
         /// <summary>
         /// The MD5 hash of the host. Meaningful if <see cref="HasMD5"/> is true
         /// </summary>
@@ -29,6 +33,10 @@ public class CertificateSsh : Certificate
         /// </summary>
         public readonly bool HasSHA1;
 
+        /// <summary>
+        /// True if we have the SHA1 hostkey hash from the server
+        /// </summary>public readonly bool HasSHA1;
+
         internal CertificateSsh(GitCertificateSsh cert)
         {
 
@@ -41,12 +49,5 @@ internal CertificateSsh(GitCertificateSsh cert)
             HashSHA1 = new byte[20];
             cert.HashSHA1.CopyTo(HashSHA1, 0);
         }
-
-        /// <summary>
-        /// For mocking purposes
-        /// </summary>
-        protected CertificateSsh()
-        { }
     }
 }
-

LibGit2Sharp/CertificateX509.cs

@@ -9,6 +9,13 @@ namespace LibGit2Sharp
     /// </summary>
     public class CertificateX509 : Certificate
     {
+
+        /// <summary>
+        /// For mocking purposes
+        /// </summary>
+        protected CertificateX509()
+        { }
+
         /// <summary>
         /// The certificate.
         /// </summary>
@@ -21,12 +28,5 @@ internal CertificateX509(GitCertificateX509 cert)
             Marshal.Copy(cert.data, data, 0, len);
             Certificate = new X509Certificate(data);
         }
-
-        /// <summary>
-        /// For mocking purposes
-        /// </summary>
-        protected CertificateX509()
-        { }
     }
 }
-

LibGit2Sharp/Core/CertificateNone.cs

@@ -1,5 +1,4 @@
-using System;
-using System.Runtime.InteropServices;
+using System.Runtime.InteropServices;
 
 namespace LibGit2Sharp.Core
 {
@@ -9,4 +8,3 @@ internal struct GitCertificate
         public GitCertificateType type;
     }
 }
-

LibGit2Sharp/Core/GitCertificate.cs

@@ -1,5 +1,4 @@
-using System;
-using System.Runtime.InteropServices;
+using System.Runtime.InteropServices;
 
 namespace LibGit2Sharp.Core
 {
@@ -22,4 +21,3 @@ internal struct GitCertificateSsh
         public byte[] HashSHA1;
     }
 }
-

LibGit2Sharp/Core/GitCertificateSsh.cs

@@ -9,4 +9,3 @@ internal enum GitCertificateSshType
         SHA1 = (1 << 1),
     }
 }
-

LibGit2Sharp/Core/GitCertificateSshType.cs

@@ -1,6 +1,4 @@
-using System;
-
-namespace LibGit2Sharp.Core
+namespace LibGit2Sharp.Core
 {
     /// <summary>
     /// Git certificate types to present to the user
@@ -17,4 +15,3 @@ internal enum GitCertificateType
         Hostkey = 1,
     }
 }
-

LibGit2Sharp/Core/GitCertificateType.cs

@@ -20,4 +20,3 @@ internal struct GitCertificateX509
         public UIntPtr len;
     }
 }
-