Update libgit2 binaries to 98eaf39

libgit2/libgit2@e87d9d3...98eaf39

Author: ben

Lib/NativeBinaries/amd64/git2-98eaf39.dll

@@ -2,6 +2,6 @@ namespace LibGit2Sharp.Core
 {
 	internal static class NativeDllName
 	{
-		public const string Name = "git2-e87d9d3";
+		public const string Name = "git2-98eaf39";
 	}
 }

Lib/NativeBinaries/amd64/git2-98eaf39.pdb

@@ -864,7 +864,7 @@ internal static extern int git_remote_load(
         internal delegate int git_headlist_cb(ref GitRemoteHead remoteHeadPtr, IntPtr payload);
 
         [DllImport(libgit2)]
-        internal static extern int git_remote_ls(RemoteSafeHandle remote, git_headlist_cb headlist_cb, IntPtr payload);
+        internal static extern int git_remote_ls(out IntPtr heads, out UIntPtr size, RemoteSafeHandle remote);
 
         [DllImport(libgit2)]
         [return: MarshalAs(UnmanagedType.CustomMarshaler, MarshalCookie = UniqueId.UniqueIdentifier, MarshalTypeRef = typeof(LaxUtf8NoCleanupMarshaler))]

Lib/NativeBinaries/amd64/git2-e87d9d3.dll

@@ -1569,13 +1569,34 @@ public static IList<string> git_remote_list(RepositorySafeHandle repo)
             }
         }
 
-        public static void git_remote_ls(RemoteSafeHandle remote, NativeMethods.git_headlist_cb headlist_cb)
+        public static IEnumerable<DirectReference> git_remote_ls(Repository repository, RemoteSafeHandle remote)
         {
+            var refs = new List<DirectReference>();
+            IntPtr heads;
+            UIntPtr size;
+
             using (ThreadAffinity())
             {
-                int res = NativeMethods.git_remote_ls(remote, headlist_cb, IntPtr.Zero);
+                int res = NativeMethods.git_remote_ls(out heads, out size, remote);
                 Ensure.ZeroResult(res);
             }
+
+            var grheads = Libgit2UnsafeHelper.RemoteLsHelper(heads, size);
+
+            foreach (var remoteHead in grheads)
+            {
+                // The name pointer should never be null - if it is,
+                // this indicates a bug somewhere (libgit2, server, etc).
+                if (remoteHead.NamePtr == IntPtr.Zero)
+                {
+                    throw new InvalidOperationException("Not expecting null value for reference name.");
+                }
+
+                string name = LaxUtf8Marshaler.FromNative(remoteHead.NamePtr);
+                refs.Add(new DirectReference(name, repository, remoteHead.Oid));
+            }
+
+            return refs;
         }
 
         public static RemoteSafeHandle git_remote_load(RepositorySafeHandle repo, string name, bool throwsIfNotFound)
@@ -2531,6 +2552,19 @@ public static IList<string> BuildListOf(UnSafeNativeMethods.git_strarray strArra
                     UnSafeNativeMethods.git_strarray_free(ref strArray);
                 }
             }
+
+            public static IList<GitRemoteHead> RemoteLsHelper(IntPtr heads, UIntPtr size)
+            {
+                var rawHeads = (IntPtr*) heads;
+                var count = (int) size;
+
+                var list = new List<GitRemoteHead>(count);
+                for (int i = 0; i < count; i++)
+                {
+                    list.Add((GitRemoteHead)Marshal.PtrToStructure(rawHeads[i], typeof (GitRemoteHead)));
+                }
+                return list;
+            } 
         }
 
         private static bool RepositoryStateChecker(RepositorySafeHandle repo, Func<RepositorySafeHandle, int> checker)

Lib/NativeBinaries/amd64/git2-e87d9d3.pdb

@@ -67,32 +67,11 @@ public virtual IEnumerable<DirectReference> ListReferences(Remote remote)
         {
             Ensure.ArgumentNotNull(remote, "remote");
 
-            List<DirectReference> directReferences = new List<DirectReference>();
             using (RemoteSafeHandle remoteHandle = Proxy.git_remote_load(repository.Handle, remote.Name, true))
             {
                 Proxy.git_remote_connect(remoteHandle, GitDirection.Fetch);
-
-                NativeMethods.git_headlist_cb cb = (ref GitRemoteHead remoteHead, IntPtr payload) =>
-                {
-                    // The name pointer should never be null - if it is,
-                    // this indicates a bug somewhere (libgit2, server, etc).
-                    if (remoteHead.NamePtr == IntPtr.Zero)
-                    {
-                        Proxy.giterr_set_str(GitErrorCategory.Invalid, "Not expecting null value for reference name.");
-                        return -1;
-                    }
-
-                    ObjectId oid = remoteHead.Oid;
-                    string name = LaxUtf8Marshaler.FromNative(remoteHead.NamePtr);
-                    directReferences.Add(new DirectReference(name, this.repository, oid));
-
-                    return 0;
-                };
-
-                Proxy.git_remote_ls(remoteHandle, cb);
+                return Proxy.git_remote_ls(repository, remoteHandle);
             }
-
-            return directReferences;
         }
 
         /// <summary>

Lib/NativeBinaries/x86/git2-98eaf39.dll

@@ -1 +1 @@
-e87d9d3d4d8de9c048476387931c4ac57d1c2b73
+98eaf39a87164eeb284df5c0239c3a31dfb538e7