Make Signature IEquatable

Author: nulltoken

LibGit2Sharp.Tests/TagFixture.cs

@@ -11,7 +11,7 @@ public class TagFixture : BaseFixture
     {
         private readonly string[] expectedTags = new[] { "e90810b", "lw", "point_to_blob", "test", };
 
-        private static readonly Signature signatureTim = new Signature("Tim Clem", "[email protected]", DateTimeOffset.UtcNow);
+        private static readonly Signature signatureTim = new Signature("Tim Clem", "[email protected]", TruncateSubSeconds(DateTimeOffset.UtcNow));
         private static readonly Signature signatureNtk = new Signature("nulltoken", "[email protected]", Epoch.ToDateTimeOffset(1300557894, 60));
         private const string tagTestSha = "b25fa35b38051e4ae45d4222e795f9df2e43f1d1";
         private const string commitE90810BSha = "e90810b8df3e80c413d903f631643c716887138d";
@@ -151,6 +151,7 @@ public void CanAddAnAnnotatedTagFromSha()
                 Assert.NotNull(newTag);
                 Assert.True(newTag.IsAnnotated);
                 Assert.Equal(tagTestSha, newTag.Target.Sha);
+                Assert.Equal(signatureTim, newTag.Annotation.Tagger);
             }
         }
 

LibGit2Sharp.Tests/TestHelpers/BaseFixture.cs

@@ -2,6 +2,7 @@
 using System.Collections.Generic;
 using System.IO;
 using System.Text.RegularExpressions;
+using LibGit2Sharp.Core;
 using Xunit;
 
 namespace LibGit2Sharp.Tests.TestHelpers
@@ -21,7 +22,13 @@ static BaseFixture()
         public static string StandardTestRepoPath { get; private set; }
         public static DirectoryInfo ResourcesDirectory { get; private set; }
 
-        public static readonly Signature DummySignature = new Signature("Author N. Ame", "[email protected]", DateTimeOffset.Now);
+        public static readonly Signature DummySignature = new Signature("Author N. Ame", "[email protected]", TruncateSubSeconds(DateTimeOffset.Now));
+
+        protected static DateTimeOffset TruncateSubSeconds(DateTimeOffset dto)
+        {
+            int seconds = dto.ToSecondsSinceEpoch();
+            return Epoch.ToDateTimeOffset(seconds, (int) dto.Offset.TotalMinutes);
+        }
 
         private static void SetUpTestEnvironment()
         {

LibGit2Sharp/Signature.cs

@@ -8,12 +8,15 @@ namespace LibGit2Sharp
     /// <summary>
     ///   A signature
     /// </summary>
-    public class Signature
+    public class Signature : IEquatable<Signature>
     {
         private readonly DateTimeOffset when;
         private readonly string name;
         private readonly string email;
 
+        private static readonly LambdaEqualityHelper<Signature> equalityHelper =
+            new LambdaEqualityHelper<Signature>(x => x.Name, x => x.Email, x => x.When);
+
         internal Signature(IntPtr signaturePtr)
         {
             var handle = new GitSignature();
@@ -65,5 +68,56 @@ public DateTimeOffset When
         {
             get { return when; }
         }
+
+        /// <summary>
+        ///   Determines whether the specified <see cref = "Object" /> is equal to the current <see cref = "Signature" />.
+        /// </summary>
+        /// <param name = "obj">The <see cref = "Object" /> to compare with the current <see cref = "Signature" />.</param>
+        /// <returns>True if the specified <see cref = "Object" /> is equal to the current <see cref = "Signature" />; otherwise, false.</returns>
+        public override bool Equals(object obj)
+        {
+            return Equals(obj as Signature);
+        }
+
+        /// <summary>
+        ///   Determines whether the specified <see cref = "Signature" /> is equal to the current <see cref = "Signature" />.
+        /// </summary>
+        /// <param name = "other">The <see cref = "Signature" /> to compare with the current <see cref = "Signature" />.</param>
+        /// <returns>True if the specified <see cref = "Signature" /> is equal to the current <see cref = "Signature" />; otherwise, false.</returns>
+        public bool Equals(Signature other)
+        {
+            return equalityHelper.Equals(this, other);
+        }
+
+        /// <summary>
+        ///   Returns the hash code for this instance.
+        /// </summary>
+        /// <returns>A 32-bit signed integer hash code.</returns>
+        public override int GetHashCode()
+        {
+            return equalityHelper.GetHashCode(this);
+        }
+
+        /// <summary>
+        ///   Tests if two <see cref = "Signature" /> are equal.
+        /// </summary>
+        /// <param name = "left">First <see cref = "Signature" /> to compare.</param>
+        /// <param name = "right">Second <see cref = "Signature" /> to compare.</param>
+        /// <returns>True if the two objects are equal; false otherwise.</returns>
+        public static bool operator ==(Signature left, Signature right)
+        {
+            return Equals(left, right);
+        }
+
+        /// <summary>
+        ///   Tests if two <see cref = "Signature" /> are different.
+        /// </summary>
+        /// <param name = "left">First <see cref = "Signature" /> to compare.</param>
+        /// <param name = "right">Second <see cref = "Signature" /> to compare.</param>
+        /// <returns>True if the two objects are different; false otherwise.</returns>
+        public static bool operator !=(Signature left, Signature right)
+        {
+            return !Equals(left, right);
+        }
     }
 }