Skip to content

Prevent garbage collection of checkout callbacks. #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Prevent garbage collection of checkout callbacks. #638

wants to merge 1 commit into from

Conversation

jamill
Copy link
Member

@jamill jamill commented Mar 1, 2014

Potential fix for #635.

@jamill
Copy link
Member Author

jamill commented Mar 1, 2014

I am not sure if the opts parameter in CheckoutTree might need to be protected from garbage collection as well.

/cc @phkelley

@Yogu
Copy link
Contributor

Yogu commented Mar 18, 2014

Even if it did not fix my issue, we probably should still merge this one, right?

@nulltoken
Copy link
Member

@phkelley What's your take about this, please?

@jamill
Copy link
Member Author

jamill commented Mar 25, 2014

I would like to understand why we are seeing the original crashes. I will close this for now - if there is a real problem, we can bring this back.

@jamill jamill closed this Mar 25, 2014
@nulltoken nulltoken added this to the UnmergedOrDoNotRequireAFix milestone Mar 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
UnmergedOrDoNotRequireAFix
Development

Successfully merging this pull request may close these issues.
3 participants
@jamill @Yogu @nulltoken