Skip to content

Commit 597d394

Browse files
committed
Introduce AnchorChannelsConfig
.. allowing to configure the per-channel emergency reserve as well as some trusted peers for which we won't maintain any reserve.
1 parent eb192a9 commit 597d394

File tree

3 files changed

+82
-1
lines changed

3 files changed

+82
-1
lines changed

bindings/ldk_node.udl

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,12 @@ dictionary Config {
1515
sequence<PublicKey> trusted_peers_0conf;
1616
u64 probing_liquidity_limit_multiplier;
1717
LogLevel log_level;
18+
AnchorChannelsConfig? anchor_channels_config;
19+
};
20+
21+
dictionary AnchorChannelsConfig {
22+
sequence<PublicKey> trusted_peers_no_reserve;
23+
u64 per_channel_reserve_sats;
1824
};
1925

2026
interface Builder {

src/config.rs

Lines changed: 75 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ const DEFAULT_LDK_WALLET_SYNC_INTERVAL_SECS: u64 = 30;
1515
const DEFAULT_FEE_RATE_CACHE_UPDATE_INTERVAL_SECS: u64 = 60 * 10;
1616
const DEFAULT_PROBING_LIQUIDITY_LIMIT_MULTIPLIER: u64 = 3;
1717
const DEFAULT_LOG_LEVEL: LogLevel = LogLevel::Debug;
18+
const DEFAULT_ANCHOR_PER_CHANNEL_RESERVE_SATS: u64 = 25_000;
1819

1920
// The 'stop gap' parameter used by BDK's wallet sync. This seems to configure the threshold
2021
// number of derivation indexes after which BDK stops looking for new scripts belonging to the wallet.
@@ -62,6 +63,9 @@ pub(crate) const WALLET_KEYS_SEED_LEN: usize = 64;
6263
/// | `trusted_peers_0conf` | [] |
6364
/// | `probing_liquidity_limit_multiplier` | 3 |
6465
/// | `log_level` | Debug |
66+
/// | `anchor_channels_config` | Some(..) |
67+
///
68+
/// See [`AnchorChannelsConfig`] for more information on its respective default values.
6569
///
6670
/// [`Node`]: crate::Node
6771
pub struct Config {
@@ -104,6 +108,21 @@ pub struct Config {
104108
///
105109
/// Any messages below this level will be excluded from the logs.
106110
pub log_level: LogLevel,
111+
/// Configuration options pertaining to Anchor channels, i.e., channels for which the
112+
/// `option_anchors_zero_fee_htlc_tx` channel type is negotiated.
113+
///
114+
/// Please refer to [`AnchorChannelsConfig`] for further information on Anchor channels.
115+
///
116+
/// If set to `Some`, new channels will have Anchors enabled, i.e., will be negotiated with the
117+
/// `option_anchors_zero_fee_htlc_tx` channel type. If set to `None`, new channels will be
118+
/// negotiated with the legacy `option_static_remotekey` channel type.
119+
///
120+
/// **Note:** Please note that if set to `None` *after* some Anchor channels have already been
121+
/// opened, no dedicated emergency on-chain reserve will be maintained for these channels,
122+
/// which can be dangerous if only insufficient funds are available at the time of channel
123+
/// closure. We *will* however still try to get the Anchor spending transactions confirmed
124+
/// on-chain with the funds available.
125+
pub anchor_channels_config: Option<AnchorChannelsConfig>,
107126
}
108127

109128
impl Default for Config {
@@ -120,6 +139,62 @@ impl Default for Config {
120139
trusted_peers_0conf: Vec::new(),
121140
probing_liquidity_limit_multiplier: DEFAULT_PROBING_LIQUIDITY_LIMIT_MULTIPLIER,
122141
log_level: DEFAULT_LOG_LEVEL,
142+
anchor_channels_config: Some(AnchorChannelsConfig::default()),
143+
}
144+
}
145+
}
146+
147+
/// Configuration options pertaining to 'Anchor' channels, i.e., channels for which the
148+
/// `option_anchors_zero_fee_htlc_tx` channel type is negotiated.
149+
///
150+
/// Prior to the introduction of Anchor channels, the on-chain fees paying for the transactions
151+
/// issued on channel closure were pre-determined and locked-in at the time of the channel
152+
/// opening. This required to estimate what fee rate would be sufficient to still have the
153+
/// closing transactions be spendable on-chain (i.e., not be considered dust). This legacy
154+
/// design of pre-anchor channels proved inadequate in the unpredictable, often turbulent, fee
155+
/// markets we experience today. In contrast, Anchor channels allow to determine an adequate
156+
/// fee rate *at the time of channel closure*, making them much more robust in the face of fee
157+
/// spikes. In turn, they require to maintain a reserve of on-chain funds to be able to get the
158+
/// channel closure transactions confirmed on-chain, at least if the channel counterparty can't
159+
/// be trusted to this for us.
160+
///
161+
/// See [BOLT 3] for more technical details on Anchor channels.
162+
///
163+
///
164+
/// ### Defaults
165+
///
166+
/// | Parameter | Value |
167+
/// |----------------------------|--------|
168+
/// | `trusted_peers_no_reserve` | [] |
169+
/// | `per_channel_reserve_sats` | 25000 |
170+
///
171+
///
172+
/// [BOLT 3]: https://github.com/lightning/bolts/blob/master/03-transactions.md#htlc-timeout-and-htlc-success-transactions
173+
#[derive(Debug, Clone)]
174+
pub struct AnchorChannelsConfig {
175+
/// A list of peers which we trust to spend the anchor output *for us* on channel closing.
176+
///
177+
/// Channels with these peers won't count towards the retained on-chain reserve and we won't
178+
/// take any action to get the Anchor spending transactions confirmed.
179+
///
180+
/// **Note:** Trusting the channel counterparty to spend the anchor output is potentially
181+
/// insecure as the channel may not be closed if they refuse to do so, potentially leaving the
182+
/// user funds stuck.
183+
pub trusted_peers_no_reserve: Vec<PublicKey>,
184+
/// The amount of satoshis we keep as an emergency reserve in our on-chain wallet in order to
185+
/// be able to spend the Anchor output on channel close.
186+
///
187+
/// **Note:** Depending on the fee market at the time of closure, this reserve amount might or
188+
/// might not suffice to successfully spend the Anchor output, i.e., you may want to adjust
189+
/// this value accordingly.
190+
pub per_channel_reserve_sats: u64,
191+
}
192+
193+
impl Default for AnchorChannelsConfig {
194+
fn default() -> Self {
195+
Self {
196+
trusted_peers_no_reserve: Vec::new(),
197+
per_channel_reserve_sats: DEFAULT_ANCHOR_PER_CHANNEL_RESERVE_SATS,
123198
}
124199
}
125200
}

src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ pub use lightning;
100100
pub use lightning_invoice;
101101

102102
pub use balance::{BalanceDetails, LightningBalance, PendingSweepBalance};
103-
pub use config::{default_config, Config};
103+
pub use config::{default_config, AnchorChannelsConfig, Config};
104104
pub use error::Error as NodeError;
105105
use error::Error;
106106

0 commit comments

Comments
 (0)