Skip to content

Commit b7ada42

Browse files
committed
f Drop lock before notify_one()
1 parent 0a0d8b3 commit b7ada42

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

src/event.rs

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -151,10 +151,11 @@ impl<K: KVStorePersister> LdkLiteEventQueue<K> {
151151
Self { queue, notifier, persister }
152152
}
153153
pub(crate) fn add_event(&self, event: LdkLiteEvent) -> Result<(), Error> {
154-
let mut locked_queue = self.queue.lock().unwrap();
155-
locked_queue.0.push_back(event);
156-
157-
self.persister.persist(EVENTS_PERSISTENCE_KEY, &*locked_queue)?;
154+
{
155+
let mut locked_queue = self.queue.lock().unwrap();
156+
locked_queue.0.push_back(event);
157+
self.persister.persist(EVENTS_PERSISTENCE_KEY, &*locked_queue)?;
158+
}
158159

159160
self.notifier.notify_one();
160161
Ok(())
@@ -169,9 +170,11 @@ impl<K: KVStorePersister> LdkLiteEventQueue<K> {
169170
}
170171

171172
pub(crate) fn event_handled(&self) -> Result<(), Error> {
172-
let mut locked_queue = self.queue.lock().unwrap();
173-
locked_queue.0.pop_front();
174-
self.persister.persist(EVENTS_PERSISTENCE_KEY, &*locked_queue)?;
173+
{
174+
let mut locked_queue = self.queue.lock().unwrap();
175+
locked_queue.0.pop_front();
176+
self.persister.persist(EVENTS_PERSISTENCE_KEY, &*locked_queue)?;
177+
}
175178
self.notifier.notify_one();
176179
Ok(())
177180
}

0 commit comments

Comments
 (0)