Skip to content

Commit 067dd3b

Browse files
authored
fixes per arik feedback
1 parent 2314b0a commit 067dd3b

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

CONTRIBUTING.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ you'll learn.
1515
Communications Channels
1616
-----------------------
1717

18-
Communication about Rust-Lightning happens primarily on #ldk-dev on the [LDK slack](http://www.lightningdevkit.org/)
19-
or #rust-bitcoin on IRC Freenode.
18+
Communication about Rust-Lightning happens primarily on #ldk-dev on the [LDK slack](http://www.lightningdevkit.org/),
19+
but also #rust-bitcoin on IRC Freenode.
2020

2121
Discussion about code base improvements happens in GitHub issues and on pull
2222
requests.
@@ -45,11 +45,11 @@ must be given to the long term technical debt. Every new features should
4545
be covered by functional tests.
4646

4747
When refactoring, structure your PR to make it easy to review and don't
48-
hestitate to split in multiple small, focused PRs.
48+
hestitate to split it into multiple small, focused PRs.
4949

5050
The Minimal Supported Rust Version is 1.22.0 (enforced by our Travis).
5151

52-
Commit should cover both issues fixed and solutions rationale.
52+
Commits should cover both issues fixed and solutions' rationale.
5353
These [guidelines](https://chris.beams.io/posts/git-commit/) should be kept in mind.
5454

5555
Peer review
@@ -72,22 +72,22 @@ Security
7272

7373
Security is the primary focus of Rust-Lightning; disclosure of security vulnerabilites
7474
helps prevent user loss of funds. If you believe a vulnerability may affect other Lightning
75-
implementations please inform them.
75+
implementations, please inform them.
7676

7777
Note that Rust-Lightning is currently considered "pre-production" during this time, there
78-
is no special handling of security issues. Please simpy open an issue on Github.
78+
is no special handling of security issues. Please simply open an issue on Github.
7979

8080
Testing
8181
-------
8282

8383
Related to the security aspect, Rust-Lightning developers take testing
84-
very seriously. Due to the modular nature of the project writing new functional
84+
very seriously. Due to the modular nature of the project, writing new functional
8585
tests is easy and good test coverage of the codebase is an important goal. Refactoring
8686
the project to enable fine-grained unit testing is also an ongoing effort.
8787

88-
Fuzzing is heavily encouraged: you will find all related fuzzing stuff under `fuzz/`
88+
Fuzzing is heavily encouraged: you will find all related material under `fuzz/`
8989

90-
Mutation testing is work-in-progess; any contribution there would be warmly welcomed.
90+
Mutation testing is work-in-progress; any contribution there would be warmly welcomed.
9191

9292
Going further
9393
-------------

0 commit comments

Comments
 (0)