Skip to content

Commit 0c5e351

Browse files
authored
made fixes per val and matt feedback
1 parent 3cfd07f commit 0c5e351

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

CONTRIBUTING.md

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,14 @@ you'll learn.
1515
Communications Channels
1616
-----------------------
1717

18-
Communication about Rust-Lightning happens primarily on #ldk-dev on the [LDK slack](http://www.lightningdevkit.org/),
19-
but also #rust-bitcoin on IRC Freenode.
18+
Communication about Rust-Lightning happens primarily on #ldk-dev on the
19+
[LDK slack](http://www.lightningdevkit.org/), but also #rust-bitcoin on IRC Freenode.
2020

2121
Discussion about code base improvements happens in GitHub issues and on pull
2222
requests.
2323

24-
Major projects are tracked [here](https://github.com/rust-bitcoin/rust-lightning/projects). Major milestones are tracked [here](https://github.com/rust-bitcoin/rust-lightning/milestones?direction=asc&sort=title&state=open).
24+
Major projects are tracked [here](https://github.com/rust-bitcoin/rust-lightning/projects).
25+
Major milestones are tracked [here](https://github.com/rust-bitcoin/rust-lightning/milestones?direction=asc&sort=title&state=open).
2526

2627
Contribution Workflow
2728
---------------------
@@ -51,10 +52,14 @@ hestitate to split it into multiple small, focused PRs.
5152

5253
The Minimal Supported Rust Version is 1.22.0 (enforced by our Travis).
5354

54-
Commits should cover both issues fixed and solutions' rationale.
55+
Commits should cover both the issue fixed and the solution's rationale.
5556
These [guidelines](https://chris.beams.io/posts/git-commit/) should be kept in mind.
5657

57-
To facilitate communication with other contributors, if you are working on a GitHub Issue please assign it to yourself using GitHub's "assignee" field.
58+
To facilitate communication with other contributors, the project is making use of
59+
GitHub's "assignee" field. First check that no one is assigned and then comment
60+
suggesting that you're working on it. If someone is already assigned, don't hesitate
61+
to ask if the assigned party or previous commenters are still working on it if it has
62+
been awhile.
5863

5964
Peer review
6065
-----------
@@ -98,6 +103,7 @@ Going further
98103

99104
You may be interested by Jon Atack guide on [How to review Bitcoin Core PRs](https://github.com/jonatack/bitcoin-development/blob/master/how-to-review-bitcoin-core-prs.md)
100105
and [How to make Bitcoin Core PRs](https://github.com/jonatack/bitcoin-development/blob/master/how-to-make-bitcoin-core-prs.md).
101-
While there are differences between the projects in terms of context and maturity, many of the suggestions offered apply to this project.
106+
While there are differences between the projects in terms of context and maturity, many
107+
of the suggestions offered apply to this project.
102108

103109
Overall, have fun :)

0 commit comments

Comments
 (0)