Skip to content

Commit 0d646b7

Browse files
committed
Drop test_esplora_connects_to_public_server
`blockstream.info` is currently down, causing our CI to fail. This shouldn't really be a thing, so we drop the blockstream.info-based test here. More generally, I'm not really a fan of having tests which run (outside of CI) and call out to external servers - a developer working on LDK shouldn't have to have internet access to run our test suite and shouldn't be registering their presence with a third party to run our tests.
1 parent 050f5a9 commit 0d646b7

File tree

1 file changed

+0
-17
lines changed

1 file changed

+0
-17
lines changed

lightning-transaction-sync/tests/integration_tests.rs

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -321,20 +321,3 @@ async fn test_esplora_syncs() {
321321
_ => panic!("Unexpected event"),
322322
}
323323
}
324-
325-
#[tokio::test]
326-
#[cfg(any(feature = "esplora-async-https", feature = "esplora-blocking"))]
327-
async fn test_esplora_connects_to_public_server() {
328-
let mut logger = TestLogger {};
329-
let esplora_url = "https://blockstream.info/api".to_string();
330-
let tx_sync = EsploraSyncClient::new(esplora_url, &mut logger);
331-
let confirmable = TestConfirmable::new();
332-
333-
// Check we connect and pick up on new best blocks
334-
assert_eq!(confirmable.best_block.lock().unwrap().1, 0);
335-
#[cfg(feature = "esplora-async-https")]
336-
tx_sync.sync(vec![&confirmable]).await.unwrap();
337-
#[cfg(feature = "esplora-blocking")]
338-
tx_sync.sync(vec![&confirmable]).unwrap();
339-
assert_ne!(confirmable.best_block.lock().unwrap().1, 0);
340-
}

0 commit comments

Comments
 (0)