Skip to content

Commit 10580f5

Browse files
committed
Correct send-bounding logic in TestRoutingMessageHandler
The `cmp::min` appeared to confused `end` for a count.
1 parent 2bf39a6 commit 10580f5

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

lightning/src/util/test_utils.rs

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,6 @@ fn get_dummy_channel_update(short_chan_id: u64) -> msgs::ChannelUpdate {
311311
pub struct TestRoutingMessageHandler {
312312
pub chan_upds_recvd: AtomicUsize,
313313
pub chan_anns_recvd: AtomicUsize,
314-
pub chan_anns_sent: AtomicUsize,
315314
pub request_full_sync: AtomicBool,
316315
}
317316

@@ -320,7 +319,6 @@ impl TestRoutingMessageHandler {
320319
TestRoutingMessageHandler {
321320
chan_upds_recvd: AtomicUsize::new(0),
322321
chan_anns_recvd: AtomicUsize::new(0),
323-
chan_anns_sent: AtomicUsize::new(0),
324322
request_full_sync: AtomicBool::new(false),
325323
}
326324
}
@@ -339,8 +337,8 @@ impl msgs::RoutingMessageHandler for TestRoutingMessageHandler {
339337
}
340338
fn get_next_channel_announcements(&self, starting_point: u64, batch_amount: u8) -> Vec<(msgs::ChannelAnnouncement, Option<msgs::ChannelUpdate>, Option<msgs::ChannelUpdate>)> {
341339
let mut chan_anns = Vec::new();
342-
const TOTAL_UPDS: u64 = 100;
343-
let end: u64 = cmp::min(starting_point + batch_amount as u64, TOTAL_UPDS - self.chan_anns_sent.load(Ordering::Acquire) as u64);
340+
const TOTAL_UPDS: u64 = 50;
341+
let end: u64 = cmp::min(starting_point + batch_amount as u64, TOTAL_UPDS);
344342
for i in starting_point..end {
345343
let chan_upd_1 = get_dummy_channel_update(i);
346344
let chan_upd_2 = get_dummy_channel_update(i);
@@ -349,7 +347,6 @@ impl msgs::RoutingMessageHandler for TestRoutingMessageHandler {
349347
chan_anns.push((chan_ann, Some(chan_upd_1), Some(chan_upd_2)));
350348
}
351349

352-
self.chan_anns_sent.fetch_add(chan_anns.len(), Ordering::AcqRel);
353350
chan_anns
354351
}
355352

0 commit comments

Comments
 (0)