f - Change height checks to debug assertions

Author: jkczyz

lightning-block-sync/src/lib.rs

@@ -283,14 +283,15 @@ impl<C: Cache> ChainNotifier<C> {
 		let mut previous = *prev_header;
 		loop {
 			// Found the parent block.
-			if current.height == previous.height + 1 &&
-					current.header.prev_blockhash == previous.block_hash {
+			if current.header.prev_blockhash == previous.block_hash {
+				debug_assert_eq!(current.height, previous.height + 1);
 				steps.push(ForkStep::ConnectBlock(current));
 				break;
 			}
 
 			// Found a chain fork.
 			if current.header.prev_blockhash == previous.header.prev_blockhash {
+				debug_assert_eq!(current.height, previous.height);
 				let fork_point = self.look_up_previous_header(chain_poller, &previous).await?;
 				steps.push(ForkStep::DisconnectBlock(previous));
 				steps.push(ForkStep::ConnectBlock(current));