Support expiring async payments blinded message paths

Store an absolute expiry in blinded message contexts for inbound async
payments. Without this, anyone with the path corresponding to this context is
able to trivially ask if we're online forever.

Author: valentinewallace

lightning/src/blinded_path/message.rs

@@ -419,6 +419,10 @@ pub enum AsyncPaymentsContext {
 		///
 		/// [`HeldHtlcAvailable`]: crate::onion_message::async_payments::HeldHtlcAvailable
 		hmac: Hmac<Sha256>,
+		/// The time as duration since the Unix epoch at which this path expires and messages sent over
+		/// it should be ignored. Without this, anyone with the path corresponding to this context is
+		/// able to trivially ask if we're online forever.
+		path_absolute_expiry: core::time::Duration,
 	},
 }
 
@@ -454,6 +458,7 @@ impl_writeable_tlv_based_enum!(AsyncPaymentsContext,
 	(1, InboundPayment) => {
 		(0, nonce, required),
 		(2, hmac, required),
+		(4, path_absolute_expiry, required),
 	},
 );
 

lightning/src/ln/channelmanager.rs

@@ -9966,8 +9966,11 @@ where
 
 		let nonce = Nonce::from_entropy_source(entropy);
 		let hmac = signer::hmac_for_held_htlc_available_context(nonce, expanded_key);
+		let path_absolute_expiry = Duration::from_secs(
+			inbound_payment::calculate_absolute_expiry(created_at.as_secs(), relative_expiry_secs)
+		);
 		let context = MessageContext::AsyncPayments(
-			AsyncPaymentsContext::InboundPayment { nonce, hmac }
+			AsyncPaymentsContext::InboundPayment { nonce, hmac, path_absolute_expiry }
 		);
 		let async_receive_message_paths = self.create_blinded_paths(context)
 			.map_err(|()| Bolt12SemanticError::MissingPaths)?;

lightning/src/ln/inbound_payment.rs

@@ -213,6 +213,15 @@ pub(super) fn create_for_spontaneous_payment(
 	Ok(construct_payment_secret(&iv_bytes, &metadata_bytes, &keys.metadata_key))
 }
 
+pub(super) fn calculate_absolute_expiry(highest_seen_timestamp: u64, invoice_expiry_delta_secs: u32) -> u64 {
+	// We assume that highest_seen_timestamp is pretty close to the current time - it's updated when
+	// we receive a new block with the maximum time we've seen in a header. It should never be more
+	// than two hours in the future.  Thus, we add two hours here as a buffer to ensure we
+	// absolutely never fail a payment too early.
+	// Note that we assume that received blocks have reasonably up-to-date timestamps.
+	highest_seen_timestamp + invoice_expiry_delta_secs as u64 + 7200
+}
+
 fn construct_metadata_bytes(min_value_msat: Option<u64>, payment_type: Method,
 	invoice_expiry_delta_secs: u32, highest_seen_timestamp: u64, min_final_cltv_expiry_delta: Option<u16>) -> Result<[u8; METADATA_LEN], ()> {
 	if min_value_msat.is_some() && min_value_msat.unwrap() > MAX_VALUE_MSAT {
@@ -225,12 +234,7 @@ fn construct_metadata_bytes(min_value_msat: Option<u64>, payment_type: Method,
 	};
 	min_amt_msat_bytes[0] |= (payment_type as u8) << METHOD_TYPE_OFFSET;
 
-	// We assume that highest_seen_timestamp is pretty close to the current time - it's updated when
-	// we receive a new block with the maximum time we've seen in a header. It should never be more
-	// than two hours in the future.  Thus, we add two hours here as a buffer to ensure we
-	// absolutely never fail a payment too early.
-	// Note that we assume that received blocks have reasonably up-to-date timestamps.
-	let expiry_timestamp = highest_seen_timestamp + invoice_expiry_delta_secs as u64 + 7200;
+	let expiry_timestamp = calculate_absolute_expiry(highest_seen_timestamp, invoice_expiry_delta_secs);
 	let mut expiry_bytes = expiry_timestamp.to_be_bytes();
 
 	// `min_value_msat` should fit in (64 bits - 3 payment type bits =) 61 bits as an unsigned integer.