Skip to content

Commit 1f41457

Browse files
committed
Pin memchr in our release dependency list due to core2 using it
We're working with rust-bitcoin to remove the `core2` dependency at rust-bitcoin/rust-bitcoin#2066 but until that lands and we can upgrade rust-bitcoin we're stuck with it. In the mean time, we should still pass our MSRV tests.
1 parent 0d646b7 commit 1f41457

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

ci/ci-tests.sh

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,11 @@ function PIN_RELEASE_DEPS {
1818
# The serde_json crate switched to Rust edition 2021 starting with v1.0.101, i.e., has MSRV of 1.56
1919
[ "$RUSTC_MINOR_VERSION" -lt 56 ] && cargo update -p serde_json --precise "1.0.100" --verbose
2020

21+
# The memchr crate switched to an MSRV of 1.60 starting with v2.6.0
22+
# This is currently only a release dependency via core2, which we intend to work with
23+
# rust-bitcoin to remove soon.
24+
[ "$RUSTC_MINOR_VERSION" -lt 60 ] && cargo update -p memchr --precise "2.5.0" --verbose
25+
2126
return 0 # Don't fail the script if our rustc is higher than the last check
2227
}
2328

@@ -123,6 +128,10 @@ if [[ $RUSTC_MINOR_VERSION -gt 67 ]]; then
123128
# lightning-transaction-sync's MSRV is 1.67
124129
cargo check --verbose --color always --features lightning-transaction-sync
125130
else
131+
# The memchr crate switched to an MSRV of 1.60 starting with v2.6.0
132+
# This is currently only a release dependency via core2, which we intend to work with
133+
# rust-bitcoin to remove soon.
134+
[ "$RUSTC_MINOR_VERSION" -lt 60 ] && cargo update -p memchr --precise "2.5.0" --verbose
126135
cargo check --verbose --color always
127136
fi
128137
popd

0 commit comments

Comments
 (0)