f add trivial test of scid-before-update-broadcast

Author: TheBlueMatt

lightning/src/ln/priv_short_conf_tests.rs

@@ -798,6 +798,31 @@ fn test_0conf_channel_with_async_monitor() {
 	send_payment(&nodes[0], &[&nodes[1]], 100_000);
 }
 
+#[test]
+fn test_0conf_close_no_early_chan_update() {
+	// Tests that even with a public channel 0conf channel, we don't generate a channel_update on
+	// closing.
+	let chanmon_cfgs = create_chanmon_cfgs(2);
+	let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
+	let mut chan_config = test_default_channel_config();
+	chan_config.manually_accept_inbound_channels = true;
+
+	let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, Some(chan_config)]);
+	let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
+
+	// This is the default but we force it on anyway
+	chan_config.channel_options.announced_channel = true;
+	open_zero_conf_channel(&nodes[0], &nodes[1], Some(chan_config));
+
+	// We can use the channel immediately, but won't generate a channel_update until we get confs
+	send_payment(&nodes[0], &[&nodes[1]], 100_000);
+
+	nodes[0].node.force_close_all_channels();
+	check_added_monitors!(nodes[0], 1);
+	check_closed_event!(&nodes[0], 1, ClosureReason::HolderForceClosed);
+	let _ = get_err_msg!(nodes[0], nodes[1].node.get_our_node_id());
+}
+
 #[test]
 fn test_public_0conf_channel() {
 	// Tests that we will announce a public channel (after confirmation) even if its 0conf.