Skip to content

Commit 20bd2b1

Browse files
authored
Merge pull request #366 from TheBlueMatt/2019-07-useless-todo-removal
Drop some useless TODO messages to clean things up pre-0.1
2 parents 2fd2fef + ce6f561 commit 20bd2b1

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

src/ln/channel.rs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -909,8 +909,6 @@ impl Channel {
909909
{
910910
// Make sure that the to_self/to_remote is always either past the appropriate
911911
// channel_reserve *or* it is making progress towards it.
912-
// TODO: This should happen after fee calculation, but we don't handle that correctly
913-
// yet!
914912
let mut max_commitment_tx_output = if generated_by_local {
915913
self.max_commitment_tx_output_local.lock().unwrap()
916914
} else {
@@ -2452,7 +2450,7 @@ impl Channel {
24522450
update_add_htlcs.len(), update_fulfill_htlcs.len(), update_fail_htlcs.len(), update_fail_malformed_htlcs.len());
24532451
msgs::CommitmentUpdate {
24542452
update_add_htlcs, update_fulfill_htlcs, update_fail_htlcs, update_fail_malformed_htlcs,
2455-
update_fee: None, //TODO: We need to support re-generating any update_fees in the last commitment_signed!
2453+
update_fee: None,
24562454
commitment_signed: self.send_commitment_no_state_update().expect("It looks like we failed to re-generate a commitment_signed we had previously sent?").0,
24572455
}
24582456
}
@@ -2833,7 +2831,6 @@ impl Channel {
28332831
self.cur_remote_commitment_transaction_number + 2
28342832
}
28352833

2836-
//TODO: Testing purpose only, should be changed in another way after #81
28372834
#[cfg(test)]
28382835
pub fn get_local_keys(&self) -> &ChannelKeys {
28392836
&self.local_keys

0 commit comments

Comments
 (0)