f - check exceeding MAX_VALUE_MSAT

Author: jkczyz

lightning/src/offers/invoice_request.rs

@@ -466,7 +466,7 @@ mod tests {
 	#[cfg(feature = "std")]
 	use core::time::Duration;
 	use crate::ln::features::InvoiceRequestFeatures;
-	use crate::ln::msgs::DecodeError;
+	use crate::ln::msgs::{DecodeError, MAX_VALUE_MSAT};
 	use crate::offers::offer::{OfferBuilder, Quantity};
 	use crate::offers::parse::{ParseError, SemanticError};
 	use crate::util::ser::{BigSize, Writeable};
@@ -704,6 +704,16 @@ mod tests {
 			Err(e) => assert_eq!(e, SemanticError::InsufficientAmount),
 		}
 
+		match OfferBuilder::new("foo".into(), recipient_pubkey())
+			.amount_msats(1000)
+			.build().unwrap()
+			.request_invoice(vec![1; 32], payer_pubkey())
+			.amount_msats(MAX_VALUE_MSAT + 1)
+		{
+			Ok(_) => panic!("expected error"),
+			Err(e) => assert_eq!(e, SemanticError::InvalidAmount),
+		}
+
 		match OfferBuilder::new("foo".into(), recipient_pubkey())
 			.amount_msats(1000)
 			.supported_quantity(Quantity::Unbounded)