f cache .txid()

Author: dunxen

lightning/src/ln/interactivetxs.rs

@@ -138,17 +138,15 @@ impl NegotiationContext {
 		}
 
 		let transaction = msg.prevtx.as_transaction();
+		let txid = transaction.txid();
 
 		if let Some(tx_out) = transaction.output.get(msg.prevtx_out as usize) {
 			if !tx_out.script_pubkey.is_witness_program() {
 				// The receiving node:
 				//  - MUST fail the negotiation if:
 				//     - the `scriptPubKey` is not a witness program
 				return Err(AbortReason::PrevTxOutInvalid);
-			} else if !self
-				.prevtx_outpoints
-				.insert(OutPoint { txid: transaction.txid(), vout: msg.prevtx_out })
-			{
+			} else if !self.prevtx_outpoints.insert(OutPoint { txid, vout: msg.prevtx_out }) {
 				// The receiving node:
 				//  - MUST fail the negotiation if:
 				//     - the `prevtx` and `prevtx_vout` are identical to a previously added
@@ -173,7 +171,7 @@ impl NegotiationContext {
 			//    - the `serial_id` is already included in the transaction
 			return Err(AbortReason::DuplicateSerialId);
 		}
-		let prev_outpoint = OutPoint { txid: transaction.txid(), vout: msg.prevtx_out };
+		let prev_outpoint = OutPoint { txid, vout: msg.prevtx_out };
 		self.inputs.insert(
 			msg.serial_id,
 			TxInputWithPrevOutput {