Implement serialize/deserialize for Router.

Extend route_test to check if serialize/deserialize of
NetworkMap works.

Add PartialEq traits on some Router's structs.

Modify also UnsignedNodeAnnouncement serialization

Author: Antoine Riard

fuzz/fuzz_targets/router_target.rs

@@ -125,7 +125,7 @@ pub fn do_test(data: &[u8]) {
 			match <($MsgType)>::read(&mut reader) {
 				Ok(msg) => msg,
 				Err(e) => match e {
-					msgs::DecodeError::UnknownVersion => return,
+					msgs::DecodeError::UnknownVersion { .. } => return,
 					msgs::DecodeError::UnknownRequiredFeature => return,
 					msgs::DecodeError::InvalidValue => return,
 					msgs::DecodeError::ExtraAddressesPerType => return,

src/ln/channel.rs

@@ -3651,7 +3651,7 @@ impl<R : ::std::io::Read> ReadableArgs<R, Arc<Logger>> for Channel {
 		let _ver: u8 = Readable::read(reader)?;
 		let min_ver: u8 = Readable::read(reader)?;
 		if min_ver > SERIALIZATION_VERSION {
-			return Err(DecodeError::UnknownVersion);
+			return Err(DecodeError::UnknownVersion { byte: min_ver });
 		}
 
 		let user_id = Readable::read(reader)?;

src/ln/channelmanager.rs

@@ -779,7 +779,7 @@ impl ChannelManager {
 			match msgs::OnionHopData::read(&mut Cursor::new(&decoded[..])) {
 				Err(err) => {
 					let error_code = match err {
-						msgs::DecodeError::UnknownVersion => 0x4000 | 1, // unknown realm byte
+						msgs::DecodeError::UnknownVersion { .. } => 0x4000 | 1, // unknown realm byte
 						_ => 0x2000 | 2, // Should never happen
 					};
 					return_err!("Unable to decode our hop data", error_code, &[0;0]);
@@ -2912,7 +2912,7 @@ impl<'a, R : ::std::io::Read> ReadableArgs<R, ChannelManagerReadArgs<'a>> for (S
 		let _ver: u8 = Readable::read(reader)?;
 		let min_ver: u8 = Readable::read(reader)?;
 		if min_ver > SERIALIZATION_VERSION {
-			return Err(DecodeError::UnknownVersion);
+			return Err(DecodeError::UnknownVersion { byte: min_ver });
 		}
 
 		let genesis_hash: Sha256dHash = Readable::read(reader)?;

src/ln/channelmonitor.rs

@@ -1913,7 +1913,7 @@ impl<R: ::std::io::Read> ReadableArgs<R, Arc<Logger>> for (Sha256dHash, ChannelM
 		let _ver: u8 = Readable::read(reader)?;
 		let min_ver: u8 = Readable::read(reader)?;
 		if min_ver > SERIALIZATION_VERSION {
-			return Err(DecodeError::UnknownVersion);
+			return Err(DecodeError::UnknownVersion { byte: min_ver });
 		}
 
 		let commitment_transaction_number_obscure_factor = <U48 as Readable<R>>::read(reader)?.0;