Fix incorrect logging during RBF or rebroadcast

morehouse · morehouse · commit 2620477aff37 · 2024-12-12T02:47:54.000-06:00
We were incorrectly logging RBF'd transactions as not RBF'd and vice
versa.
diff --git a/lightning/src/chain/onchaintx.rs b/lightning/src/chain/onchaintx.rs
@@ -504,7 +504,7 @@ impl<ChannelSigner: EcdsaChannelSigner> OnchainTxHandler<ChannelSigner> {
 				.map(|(_, new_feerate, claim)| {
 					let mut bumped_feerate = false;
 					if let Some(mut_request) = self.pending_claim_requests.get_mut(&claim_id) {
-						bumped_feerate = request.previous_feerate() > new_feerate;
+						bumped_feerate = new_feerate > request.previous_feerate();
 						mut_request.set_feerate(new_feerate);
 					}
 					match claim {

Original file line number	Diff line number	Diff line change
`@@ -504,7 +504,7 @@ impl<ChannelSigner: EcdsaChannelSigner> OnchainTxHandler<ChannelSigner> {`
`504`	`504`	`.map(\|(_, new_feerate, claim)\| {`
`505`	`505`	`let mut bumped_feerate = false;`
`506`	`506`	`if let Some(mut_request) = self.pending_claim_requests.get_mut(&claim_id) {`
`507`		`- bumped_feerate = request.previous_feerate() > new_feerate;`
	`507`	`+ bumped_feerate = new_feerate > request.previous_feerate();`
`508`	`508`	`mut_request.set_feerate(new_feerate);`
`509`	`509`	`}`
`510`	`510`	`match claim {`